Skip to content


Browse files Browse the repository at this point in the history
test: don't clobber RegExp.$_ on startup
Some tests expect it to be empty so clear it again after running a
regular expression against /proc/cpuinfo.

It didn't cause test failures on any of the CI machines, to the best of
my knowledge, because most of the time /proc/cpuinfo doesn't contain
the string it was looking for.

Fixes: #44840
PR-URL: #44864
Reviewed-By: James M Snell <>
Reviewed-By: Richard Lau <>
Reviewed-By: Rich Trott <>
Reviewed-By: Colin Ihrig <>
Reviewed-By: Luigi Pinca <>
Reviewed-By: Mohammed Keyvanzadeh <>
Reviewed-By: Antoine du Hamel <>
Reviewed-By: Darshan Sen <>
Reviewed-By: Juan José Arboleda <>
  • Loading branch information
bnoordhuis authored and danielleadams committed Oct 11, 2022
1 parent fe91beb commit 2308b71
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion test/common/index.js
Expand Up @@ -126,7 +126,9 @@ const isPi = (() => {
// the contents of `/sys/firmware/devicetree/base/model` but that doesn't
// work inside a container. Match the chipset model number instead.
const cpuinfo = fs.readFileSync('/proc/cpuinfo', { encoding: 'utf8' });
return /^Hardware\s*:\s*(.*)$/im.exec(cpuinfo)?.[1] === 'BCM2835';
const ok = /^Hardware\s*:\s*(.*)$/im.exec(cpuinfo)?.[1] === 'BCM2835';
/^/.test(''); // Clear RegExp.$_, some tests expect it to be empty.
return ok;
} catch {
return false;
Expand Down

0 comments on commit 2308b71

Please sign in to comment.