Permalink
Browse files

addons: remove semicolons from after module definition

Having semicolons there runs counter to our documentation and illicits
warnings in pedantic mode. This removes semicolons from after uses of
NODE_MODULE and NODE_MODULE_CONTEXT_AWARE_BUILTIN.

PR-URL: #12919
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
  • Loading branch information...
gabrielschulhof authored and addaleax committed May 9, 2017
1 parent b23d414 commit 276720921ba8b4428d3832867e8c6474156a75d1
@@ -14,4 +14,4 @@ extern "C" void init (Local<Object> target) {
NODE_SET_METHOD(target, "hello", Hello);
}
NODE_MODULE(binding, init);
NODE_MODULE(binding, init)
View
@@ -1116,7 +1116,7 @@ void init(Local<Object> exports) {
AtExit(at_exit_cb1, exports->GetIsolate());
}
NODE_MODULE(addon, init);
NODE_MODULE(addon, init)
} // namespace demo
```
View
@@ -4618,5 +4618,5 @@ int Start(int argc, char** argv) {
#if !HAVE_INSPECTOR
static void InitEmptyBindings() {}
NODE_MODULE_CONTEXT_AWARE_BUILTIN(inspector, InitEmptyBindings);
NODE_MODULE_CONTEXT_AWARE_BUILTIN(inspector, InitEmptyBindings)
#endif // !HAVE_INSPECTOR
View
@@ -1033,4 +1033,4 @@ void InitContextify(Local<Object> target,
} // anonymous namespace
} // namespace node
NODE_MODULE_CONTEXT_AWARE_BUILTIN(contextify, node::InitContextify);
NODE_MODULE_CONTEXT_AWARE_BUILTIN(contextify, node::InitContextify)
@@ -77,4 +77,4 @@ void init(v8::Local<v8::Object> exports, v8::Local<v8::Object> module) {
NODE_SET_METHOD(module, "exports", Method);
}
NODE_MODULE(binding, init);
NODE_MODULE(binding, init)
@@ -40,4 +40,4 @@ void init(Local<Object> exports) {
atexit(sanity_check);
}
NODE_MODULE(binding, init);
NODE_MODULE(binding, init)
@@ -41,4 +41,4 @@ void init(v8::Local<v8::Object> exports) {
NODE_SET_METHOD(exports, "check", Check);
}
NODE_MODULE(binding, init);
NODE_MODULE(binding, init)
@@ -11,4 +11,4 @@ void init(v8::Local<v8::Object> exports, v8::Local<v8::Object> module) {
NODE_SET_METHOD(module, "exports", Method);
}
NODE_MODULE(binding, init);
NODE_MODULE(binding, init)
@@ -11,4 +11,4 @@ void init(v8::Local<v8::Object> exports) {
NODE_SET_METHOD(exports, "hello", Method);
}
NODE_MODULE(binding, init);
NODE_MODULE(binding, init)
@@ -10,4 +10,4 @@ void init(v8::Local<v8::Object> exports) {
NODE_SET_METHOD(exports, "hello", Method);
}
NODE_MODULE(binding, init);
NODE_MODULE(binding, init)
@@ -38,4 +38,4 @@ void init(v8::Local<v8::Object> exports) {
NODE_SET_METHOD(exports, "run", Run);
}
NODE_MODULE(binding, init);
NODE_MODULE(binding, init)
@@ -35,4 +35,4 @@ void Initialize(v8::Local<v8::Object> exports) {
} // anonymous namespace
NODE_MODULE(binding, Initialize);
NODE_MODULE(binding, Initialize)
@@ -44,4 +44,4 @@ void init(Local<Object> exports) {
NODE_SET_METHOD(exports, "method", Method);
}
NODE_MODULE(binding, init);
NODE_MODULE(binding, init)
@@ -21,4 +21,4 @@ void init(v8::Local<v8::Object> exports) {
NODE_SET_METHOD(exports, "ensureAllocation", EnsureAllocation);
}
NODE_MODULE(binding, init);
NODE_MODULE(binding, init)
@@ -10,4 +10,4 @@ void init(v8::Local<v8::Object> exports) {
NODE_SET_METHOD(exports, "hello", Method);
}
NODE_MODULE(binding, init);
NODE_MODULE(binding, init)

0 comments on commit 2767209

Please sign in to comment.