Permalink
Browse files

build: don't build icu with -fno-rtti

ICU should be compiled with -frtti (and it sets that flag in its gyp
file) but it was also inheriting the -fno-rtti flag from common.gypi,
breaking the build on some systems.

Fixes: #8867
PR-URL: #8886
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
  • Loading branch information...
bnoordhuis authored and MylesBorins committed Sep 30, 2016
1 parent a3a184d commit 3919edb47e5871226b196ad13f621f6f8363799d
Showing with 1 addition and 0 deletions.
  1. +1 −0 tools/icu/icu-generic.gyp
@@ -69,6 +69,7 @@
[ 'os_posix == 1 and OS != "mac" and OS != "ios"', {
'cflags': [ '-Wno-deprecated-declarations' ],
'cflags_cc': [ '-frtti' ],
'cflags_cc!': [ '-fno-rtti' ],
}],
[ 'OS == "mac" or OS == "ios"', {
'xcode_settings': {'GCC_ENABLE_CPP_RTTI': 'YES' },

0 comments on commit 3919edb

Please sign in to comment.