Permalink
Browse files

test: throw Error objects instead of literals

test-tls-econnreset and test-http-response-status-message throw literals
instead of Error objects. Use common.fail() which throws an
AssertionError.

PR-URL: #11168
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
  • Loading branch information...
Trott authored and italoacasas committed Feb 4, 2017
1 parent abae264 commit 3ca483f4cc3bf8ea934f5079c22228ed24d6b8f6
Showing with 4 additions and 4 deletions.
  1. +2 −2 test/parallel/test-http-response-status-message.js
  2. +2 −2 test/parallel/test-tls-econnreset.js
@@ -1,5 +1,5 @@
'use strict';
-require('../common');
+const common = require('../common');
const assert = require('assert');
const http = require('http');
const net = require('net');
@@ -23,7 +23,7 @@ testCases.findByPath = function(path) {
return testCase.path === path;
});
if (matching.length === 0) {
- throw 'failed to find test case with path ' + path;
+ common.fail(`failed to find test case with path ${path}`);
}
return matching[0];
};
@@ -49,8 +49,8 @@ const ca = [ cert, cacert ];
let clientError = null;
let connectError = null;
-const server = tls.createServer({ ca: ca, cert: cert, key: key }, (conn) => {
- throw 'unreachable';
+const server = tls.createServer({ ca: ca, cert: cert, key: key }, () => {
+ common.fail('should be unreachable');
}).on('tlsClientError', function(err, conn) {
assert(!clientError && conn);
clientError = err;

0 comments on commit 3ca483f

Please sign in to comment.