Skip to content
Permalink
Browse files

doc: remove "make that" from onboarding.md

Refs: nodejs/remark-preset-lint-node#16

PR-URL: #28329
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
  • Loading branch information...
Trott authored and targos committed Jun 20, 2019
1 parent 79f23b5 commit 3daced70cf332499c90b1c24bd66d29be3bf55f1
Showing with 2 additions and 2 deletions.
  1. +2 −2 doc/onboarding.md
@@ -124,7 +124,7 @@ onboarding session.
* Be aware: Your opinion carries a lot of weight!
* Nits (requests for small changes that are not essential) are fine, but try to
avoid stalling the pull request.
* Note that they are nits when you comment: `Nit: change foo() to bar().`
* Identify them as nits when you comment: `Nit: change foo() to bar().`
* If they are stalling the pull request, fix them yourself on merge.
* Insofar as possible, issues should be identified by tools rather than human
reviewers. If you are leaving comments about issues that could be identified
@@ -191,7 +191,7 @@ onboarding session.

See the Collaborator Guide: [Landing Pull Requests][].

Note that commits in one PR that belong to one logical change should
Commits in one PR that belong to one logical change should
be squashed. It is rarely the case in onboarding exercises, so this
needs to be pointed out separately during the onboarding.

0 comments on commit 3daced7

Please sign in to comment.
You can’t perform that action at this time.