Permalink
Browse files

test: refactored test-http-allow-req-after-204-res to countdown

PR-URL: #17211
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
  • Loading branch information...
mithunsasidharan authored and gibfahn committed Nov 28, 2017
1 parent 3ee4c1e commit 42454a5c34024b616bdb3ee4442ddf64a4dc6575
Showing with 5 additions and 8 deletions.
  1. +1 −0 test/common/countdown.js
  2. +4 −8 test/parallel/test-http-allow-req-after-204-res.js
View
@@ -17,6 +17,7 @@ class Countdown {
assert(this[kLimit] > 0, 'Countdown expired');
if (--this[kLimit] === 0)
this[kCallback]();
return this[kLimit];
}
get remaining() {
@@ -2,12 +2,12 @@
const common = require('../common');
const http = require('http');
const assert = require('assert');
const Countdown = require('../common/countdown');
// first 204 or 304 works, subsequent anything fails
const codes = [204, 200];
// Methods don't really matter, but we put in something realistic.
const methods = ['DELETE', 'DELETE'];
const countdown = new Countdown(codes.length, () => server.close());
const server = http.createServer(common.mustCall((req, res) => {
const code = codes.shift();
@@ -18,17 +18,13 @@ const server = http.createServer(common.mustCall((req, res) => {
}, codes.length));
function nextRequest() {
const method = methods.shift();
const request = http.request({
const request = http.get({
port: server.address().port,
method: method,
path: '/'
}, common.mustCall((response) => {
response.on('end', common.mustCall(() => {
if (methods.length === 0) {
server.close();
} else {
if (countdown.dec()) {
// throws error:
nextRequest();
// works just fine:

0 comments on commit 42454a5

Please sign in to comment.