Skip to content
Permalink
Browse files

util: Remove exec, has been deprecated for years

PR-URL: #2530
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information...
geek authored and jasnell committed Aug 24, 2015
1 parent e4e5b13 commit 4cf19ad1bbfea24d5f7931e825f3f8638924a23c
Showing with 0 additions and 5 deletions.
  1. +0 −5 lib/util.js
@@ -838,11 +838,6 @@ function hasOwnProperty(obj, prop) {

// Deprecated old stuff.

exports.exec = internalUtil.deprecate(function() {
return require('child_process').exec.apply(this, arguments);
}, 'util.exec is deprecated. Use child_process.exec instead.');


exports.print = internalUtil.deprecate(function() {
for (var i = 0, len = arguments.length; i < len; ++i) {
process.stdout.write(String(arguments[i]));

5 comments on commit 4cf19ad

@cjihrig

This comment has been minimized.

Copy link
Contributor

replied Nov 18, 2015

Remove should be remove in the commit title

@jasnell

This comment has been minimized.

Copy link
Member

replied Nov 18, 2015

doh! dangnabbit!!

@Fishrock123

This comment has been minimized.

Copy link
Member

replied Nov 18, 2015

Umm, does that really matter? I've seen lots of commits with both?

@jasnell

This comment has been minimized.

Copy link
Member

replied Nov 18, 2015

Not critical but it's good to be consistent. Only I keep not being lol

@cjihrig

This comment has been minimized.

Copy link
Contributor

replied Nov 18, 2015

I guess it's not explicitly called out in CONTRIBUTING.md. I thought it was. The example there uses all starts with lowercase. If that's not the policy, then sorry for the false alarm :-)

Please sign in to comment.
You can’t perform that action at this time.