Permalink
Browse files

test: refactor test-repl-sigint

* remove debugging code that prints child stdout
* indexOf() -> includes()
* improved messages on assertion failures

PR-URL: #11309
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
  • Loading branch information...
Trott authored and italoacasas committed Feb 11, 2017
1 parent 1f3eee4 commit 5350f04e428232ef4dfe147e61528949d1775d8e
Showing with 8 additions and 10 deletions.
  1. +8 −10 test/parallel/test-repl-sigint.js
@@ -17,18 +17,10 @@ const child = spawn(process.execPath, [ '-i' ], {
let stdout = '';
child.stdout.setEncoding('utf8');
-child.stdout.pipe(process.stdout);
child.stdout.on('data', function(c) {
stdout += c;
});
-child.stdin.write = ((original) => {
- return (chunk) => {
- process.stderr.write(chunk);
- return original.call(child.stdin, chunk);
- };
-})(child.stdin.write);
-
child.stdout.once('data', common.mustCall(() => {
process.on('SIGUSR2', common.mustCall(() => {
process.kill(child.pid, 'SIGINT');
@@ -45,6 +37,12 @@ child.stdout.once('data', common.mustCall(() => {
child.on('close', function(code) {
assert.strictEqual(code, 0);
- assert.notStrictEqual(stdout.indexOf('Script execution interrupted.\n'), -1);
- assert.notStrictEqual(stdout.indexOf('42042\n'), -1);
+ assert.ok(
+ stdout.includes('Script execution interrupted.\n'),
+ `Expected stdout to contain "Script execution interrupted.", got ${stdout}`
+ );
+ assert.ok(
+ stdout.includes('42042\n'),
+ `Expected stdout to contain "42042", got ${stdout}`
+ );
});

0 comments on commit 5350f04

Please sign in to comment.