Skip to content
Permalink
Browse files

build: run flaky tests in Travis

Skipping flaky tests in CI is an anti-pattern that should be avoided,
as we do in our ownCI. Failing flaky tests don’t need to be blockers
for a green CI result, but they should be run and reported *somehow*.

PR-URL: #27158
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information...
addaleax authored and Trott committed Mar 30, 2019
1 parent 9b859f5 commit 56354d480dade220e959f8990b69dab633066bb5
Showing with 1 addition and 1 deletion.
  1. +1 −1 .travis.yml
@@ -65,4 +65,4 @@ jobs:
- make -j2 > /dev/null
- make -j1 build-addons build-js-native-api-tests build-node-api-tests > /dev/null
script:
- JOBS=2 FLAKY_TESTS=skip make -s -j1 V= test-ci | grep -F -e "---" -e "..." -v
- JOBS=2 FLAKY_TESTS=dontcare make -s -j1 V= test-ci | grep -F -e "---" -e "..." -v

0 comments on commit 56354d4

Please sign in to comment.
You can’t perform that action at this time.