Permalink
Browse files

test: increase coverage for http2 response headers

Expanded an existing test for setting pseudo-headers on response to
include all pseudo-headers, not just :status.

PR-URL: #15035
Refs: #14985
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
  • Loading branch information...
apapirovski authored and MylesBorins committed Aug 25, 2017
1 parent ebb3c2c commit 5cb6500de96d8acfd5f5d304f678393bba67980a
Showing with 14 additions and 7 deletions.
  1. +14 −7 test/parallel/test-http2-compat-serverresponse-headers.js
@@ -42,13 +42,20 @@ server.listen(0, common.mustCall(function() {
response.removeHeader(denormalised);
assert.strictEqual(response.hasHeader(denormalised), false);
assert.throws(function() {
response.setHeader(':status', 'foobar');
}, common.expectsError({
code: 'ERR_HTTP2_PSEUDOHEADER_NOT_ALLOWED',
type: Error,
message: 'Cannot set HTTP/2 pseudo-headers'
}));
[
':status',
':method',
':path',
':authority',
':scheme'
].forEach((header) => assert.throws(
() => response.setHeader(header, 'foobar'),
common.expectsError({
code: 'ERR_HTTP2_PSEUDOHEADER_NOT_ALLOWED',
type: Error,
message: 'Cannot set HTTP/2 pseudo-headers'
})
));
assert.throws(function() {
response.setHeader(real, null);
}, common.expectsError({

0 comments on commit 5cb6500

Please sign in to comment.