Skip to content
Permalink
Browse files

test: add logging in case of infinite loop

test-inspector-contexts may be entering an infinite loop (or very
long-running loop) in CI, resulting in flakiness. Or maybe not. Add
logging to find out.

PR-URL: #30649
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information
Trott authored and MylesBorins committed Nov 26, 2019
1 parent 196e08d commit 648318dc5c869ceaf19cf0aadf80237c5507c8fd
Showing with 8 additions and 0 deletions.
  1. +8 −0 test/sequential/test-inspector-contexts.js
@@ -65,8 +65,10 @@ async function testContextCreatedAndDestroyed() {
JSON.stringify(contextCreated));

// GC is unpredictable...
console.log('Checking/waiting for GC.');
while (!contextDestroyed)
global.gc();
console.log('Context destroyed.');

assert.strictEqual(contextDestroyed.params.executionContextId, id,
JSON.stringify(contextDestroyed));
@@ -95,8 +97,10 @@ async function testContextCreatedAndDestroyed() {
JSON.stringify(contextCreated));

// GC is unpredictable...
console.log('Checking/waiting for GC again.');
while (!contextDestroyed)
global.gc();
console.log('Other context destroyed.');
}

{
@@ -119,8 +123,10 @@ async function testContextCreatedAndDestroyed() {
JSON.stringify(contextCreated));

// GC is unpredictable...
console.log('Checking/waiting for GC a third time.');
while (!contextDestroyed)
global.gc();
console.log('Context destroyed once again.');
}

{
@@ -141,8 +147,10 @@ async function testContextCreatedAndDestroyed() {
JSON.stringify(contextCreated));

// GC is unpredictable...
console.log('Checking/waiting for GC a fourth time.');
while (!contextDestroyed)
global.gc();
console.log('Context destroyed a fourth time.');
}
}

0 comments on commit 648318d

Please sign in to comment.
You can’t perform that action at this time.