Skip to content
Permalink
Browse files

test: minor fixups for REPL eval tests

The `process.on("exit")` event handlers are unnecessary, so it’s okay
to drop them.

PR-URL: #11946
Ref: #11871
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
  • Loading branch information...
addaleax authored and jasnell committed Mar 20, 2017
1 parent 76279cb commit 64d0a735741558e8c715b86531b51e6f57dc3bd7
Showing with 4 additions and 8 deletions.
  1. +2 −4 test/parallel/test-repl-empty.js
  2. +2 −4 test/parallel/test-repl-eval.js
@@ -9,7 +9,7 @@ const repl = require('repl');
const options = {
eval: common.mustCall((cmd, context) => {
// Assertions here will not cause the test to exit with an error code
// so set a boolean that is checked in process.on('exit',...) instead.
// so set a boolean that is checked later instead.
evalCalledWithExpectedArgs = (cmd === '\n');
})
};
@@ -23,7 +23,5 @@ const repl = require('repl');
r.write('.exit\n');
}

process.on('exit', () => {
assert(evalCalledWithExpectedArgs);
});
assert(evalCalledWithExpectedArgs);
}
@@ -9,7 +9,7 @@ const repl = require('repl');
const options = {
eval: common.mustCall((cmd, context) => {
// Assertions here will not cause the test to exit with an error code
// so set a boolean that is checked in process.on('exit',...) instead.
// so set a boolean that is checked later instead.
evalCalledWithExpectedArgs = (cmd === 'function f() {}\n' &&
context.foo === 'bar');
})
@@ -29,7 +29,5 @@ const repl = require('repl');
r.write('.exit\n');
}

process.on('exit', () => {
assert(evalCalledWithExpectedArgs);
});
assert(evalCalledWithExpectedArgs);
}

0 comments on commit 64d0a73

Please sign in to comment.
You can’t perform that action at this time.