test: favor strict equality in http tests

PR-URL: #8151
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: jasnell - James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Author: Trott

test/parallel/test-http-agent.js

@@ -19,7 +19,7 @@ server.listen(0, function() {
       for (var j = 0; j < M; j++) {
         http.get({ port: port, path: '/' }, function(res) {
           console.log('%d %d', responses, res.statusCode);
-          if (++responses == N * M) {
+          if (++responses === N * M) {
             console.error('Received all responses, closing server');
             server.close();
           }

test/parallel/test-http-allow-req-after-204-res.js

@@ -28,7 +28,7 @@ function nextRequest() {
     path: '/'
   }, function(response) {
     response.on('end', function() {
-      if (methods.length == 0) {
+      if (methods.length === 0) {
         console.error('close server');
         server.close();
       } else {

test/parallel/test-http-client-abort.js

@@ -37,7 +37,7 @@ server.listen(0, function() {
       console.log('Client response code ' + res.statusCode);
 
       res.resume();
-      if (++responses == N) {
+      if (++responses === N) {
         console.log('All clients connected, destroying.');
         requests.forEach(function(outReq) {
           console.log('abort');

test/parallel/test-http-client-timeout-agent.js

@@ -71,6 +71,6 @@ server.listen(0, options.host, function() {
 
 process.on('exit', function() {
   console.error('done=%j sent=%j', requests_done, requests_sent);
-  assert.ok(requests_done == requests_sent,
-            'timeout on http request called too much');
+  assert.strictEqual(requests_done, requests_sent,
+                     'timeout on http request called too much');
 });

test/parallel/test-http-exceptions.js

@@ -20,6 +20,6 @@ var exception_count = 0;
 process.on('uncaughtException', function(err) {
   console.log('Caught an exception: ' + err);
   if (err.name === 'AssertionError') throw err;
-  if (++exception_count == 4) process.exit(0);
+  if (++exception_count === 4) process.exit(0);
 });
 

test/parallel/test-http-expect-continue.js

@@ -58,7 +58,7 @@ server.on('listening', function() {
       assert.equal(body, test_res_body, 'Response body doesn\'t match.');
       assert.ok('abcd' in res.headers, 'Response headers missing.');
       outstanding_reqs--;
-      if (outstanding_reqs == 0) {
+      if (outstanding_reqs === 0) {
         server.close();
         process.exit();
       }

test/parallel/test-http-get-pipeline-problem.js

@@ -19,7 +19,7 @@ var total = 10;
 var requests = 0, responses = 0;
 
 var server = http.Server(function(req, res) {
-  if (++requests == total) {
+  if (++requests === total) {
     server.close();
   }
 
@@ -51,7 +51,7 @@ server.listen(0, function() {
 
         s.on('finish', function() {
           console.error('done ' + x);
-          if (++responses == total) {
+          if (++responses === total) {
             checkFiles();
           }
         });

test/parallel/test-http-incoming-pipelined-socket-destroy.js

@@ -52,7 +52,7 @@ server.listen(0, function() {
   var client = net.connect({ port: this.address().port });
   var done = 0;
   server.on('requestDone', function() {
-    if (++done == seeds.length) {
+    if (++done === seeds.length) {
       server.close();
     }
   });

test/parallel/test-http-legacy.js

@@ -9,7 +9,7 @@ var body0 = '';
 var body1 = '';
 
 var server = http.createServer(function(req, res) {
-  if (responses_sent == 0) {
+  if (responses_sent === 0) {
     assert.equal('GET', req.method);
     assert.equal('/hello', url.parse(req.url).pathname);
 
@@ -21,7 +21,7 @@ var server = http.createServer(function(req, res) {
     assert.equal('bar', req.headers['foo']);
   }
 
-  if (responses_sent == 1) {
+  if (responses_sent === 1) {
     assert.equal('POST', req.method);
     assert.equal('/world', url.parse(req.url).pathname);
     this.close();

test/parallel/test-http-malformed-request.js

@@ -18,7 +18,7 @@ var server = http.createServer(function(req, res) {
   res.write('Hello World');
   res.end();
 
-  if (++nrequests_completed == nrequests_expected) server.close();
+  if (++nrequests_completed === nrequests_expected) server.close();
 });
 server.listen(0);