Permalink
Browse files

test: make timers-blocking-callback more reliable

test-timers-blocking-callback may fail erroneously on
resource-constrained machines due to the timing nature of the test.

There is likely no way around the timing issue. This change tries to
decrease the probability of the test failing erroneously by having it
retry a small number of times on failure.

Tested on 0.10.38 (which has a bug that this test was written for) and
(modifying the test slightly to remove ES6 stuff) the test still seems
to fail 100% of the time there, which is what we want/expect.

PR-URL: #14831
Fixes: #14792
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information...
Trott authored and MylesBorins committed Aug 14, 2017
1 parent c76a54f commit 724508295d0ea16328fcff99f6693ff9e226789b
Showing with 52 additions and 18 deletions.
  1. +52 −18 test/sequential/test-timers-blocking-callback.js
@@ -1,8 +1,9 @@
'use strict';
/*
* This is a regression test for https://github.com/joyent/node/issues/15447
* and https://github.com/joyent/node/issues/9333.
* This is a regression test for
* https://github.com/nodejs/node-v0.x-archive/issues/15447 and
* and https://github.com/nodejs/node-v0.x-archive/issues/9333.
*
* When a timer is added in another timer's callback, its underlying timer
* handle was started with a timeout that was actually incorrect.
@@ -28,17 +29,23 @@ const Timer = process.binding('timer_wrap').Timer;
const TIMEOUT = 100;
let nbBlockingCallbackCalls = 0;
let latestDelay = 0;
let timeCallbackScheduled = 0;
let nbBlockingCallbackCalls;
let latestDelay;
let timeCallbackScheduled;
// These tests are timing dependent so they may fail even when the bug is
// not present (if the host is sufficiently busy that the timers are delayed
// significantly). However, they fail 100% of the time when the bug *is*
// present, so to increase reliability, allow for a small number of retries.
let retries = 2;
function initTest() {
nbBlockingCallbackCalls = 0;
latestDelay = 0;
timeCallbackScheduled = 0;
}
function blockingCallback(callback) {
function blockingCallback(retry, callback) {
++nbBlockingCallbackCalls;
if (nbBlockingCallbackCalls > 1) {
@@ -47,34 +54,61 @@ function blockingCallback(callback) {
// to fire, they shouldn't generally be more than 100% late in this case.
// But they are guaranteed to be at least 100ms late given the bug in
// https://github.com/nodejs/node-v0.x-archive/issues/15447 and
// https://github.com/nodejs/node-v0.x-archive/issues/9333..
assert(latestDelay < TIMEOUT * 2);
// https://github.com/nodejs/node-v0.x-archive/issues/9333.
if (latestDelay >= TIMEOUT * 2) {
if (retries > 0) {
retries--;
return retry(callback);
}
assert.fail(null, null,
`timeout delayed by more than 100% (${latestDelay}ms)`);
}
if (callback)
return callback();
} else {
// block by busy-looping to trigger the issue
common.busyLoop(TIMEOUT);
timeCallbackScheduled = Timer.now();
setTimeout(blockingCallback.bind(null, callback), TIMEOUT);
setTimeout(blockingCallback.bind(null, retry, callback), TIMEOUT);
}
}
const testAddingTimerToEmptyTimersList = common.mustCall(function(callback) {
function testAddingTimerToEmptyTimersList(callback) {
initTest();
// Call setTimeout just once to make sure the timers list is
// empty when blockingCallback is called.
setTimeout(blockingCallback.bind(null, callback), TIMEOUT);
});
setTimeout(
blockingCallback.bind(null, testAddingTimerToEmptyTimersList, callback),
TIMEOUT
);
}
function testAddingTimerToNonEmptyTimersList() {
// If both timers fail and attempt a retry, only actually do anything for one
// of them.
let retryOK = true;
const retry = () => {
if (retryOK)
testAddingTimerToNonEmptyTimersList();
retryOK = false;
};
const testAddingTimerToNonEmptyTimersList = common.mustCall(function() {
initTest();
// Call setTimeout twice with the same timeout to make
// sure the timers list is not empty when blockingCallback is called.
setTimeout(blockingCallback, TIMEOUT);
setTimeout(blockingCallback, TIMEOUT);
});
setTimeout(
blockingCallback.bind(null, retry),
TIMEOUT
);
setTimeout(
blockingCallback.bind(null, retry),
TIMEOUT
);
}
// Run the test for the empty timers list case, and then for the non-empty
// timers list one
testAddingTimerToEmptyTimersList(testAddingTimerToNonEmptyTimersList);
// timers list one.
testAddingTimerToEmptyTimersList(
common.mustCall(testAddingTimerToNonEmptyTimersList)
);

0 comments on commit 7245082

Please sign in to comment.