Skip to content
Permalink
Browse files

test: use mustCall in tls-connect-given-socket

PR-URL: #12592
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information...
vperezma authored and Trott committed Apr 22, 2017
1 parent b7bc09f commit 72e3dda93c7cae1035521adc67d5b80c735a3ac3
Showing with 8 additions and 19 deletions.
  1. +8 −19 test/parallel/test-tls-connect-given-socket.js
@@ -32,26 +32,20 @@ const tls = require('tls');
const net = require('net');
const fs = require('fs');
const path = require('path');

let serverConnected = 0;
let clientConnected = 0;

const options = {
key: fs.readFileSync(path.join(common.fixturesDir, 'test_key.pem')),
cert: fs.readFileSync(path.join(common.fixturesDir, 'test_cert.pem'))
};

const server = tls.createServer(options, (socket) => {
serverConnected++;
const server = tls.createServer(options, common.mustCall((socket) => {
socket.end('Hello');
}).listen(0, () => {
}, 2)).listen(0, common.mustCall(() => {
let waiting = 2;
function establish(socket) {
function establish(socket, calls) {
const client = tls.connect({
rejectUnauthorized: false,
socket: socket
}, () => {
clientConnected++;
}, common.mustCall(() => {
let data = '';
client.on('data', common.mustCall((chunk) => {
data += chunk.toString();
@@ -61,7 +55,7 @@ const server = tls.createServer(options, (socket) => {
if (--waiting === 0)
server.close();
}));
});
}, calls));
assert(client.readable);
assert(client.writable);

@@ -72,14 +66,14 @@ const server = tls.createServer(options, (socket) => {

// Immediate death socket
const immediateDeath = net.connect(port);
establish(immediateDeath).destroy();
establish(immediateDeath, 0).destroy();

// Outliving
const outlivingTCP = net.connect(port, common.mustCall(() => {
outlivingTLS.destroy();
next();
}));
const outlivingTLS = establish(outlivingTCP);
const outlivingTLS = establish(outlivingTCP, 0);

function next() {
// Already connected socket
@@ -91,9 +85,4 @@ const server = tls.createServer(options, (socket) => {
const connecting = net.connect(port);
establish(connecting);
}
});

process.on('exit', () => {
assert.strictEqual(serverConnected, 2);
assert.strictEqual(clientConnected, 2);
});
}));

0 comments on commit 72e3dda

Please sign in to comment.
You can’t perform that action at this time.