Skip to content
Permalink
Browse files

benchmark: remove deprecated argument

The benchmarks for dns.lookup() include calling it with an empty
hostname which results in a deprecation warning. This benchmark seems to
be subject to some odd side effects (see Ref below) and we probably
generally don't want to benchmark deprecated things by default anyway.
Remove the deprecated value from the default list. Bonus is that this
will speed up the benchmark.

Refs: #27081 (comment)

PR-URL: #27091
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information...
Trott committed Apr 4, 2019
1 parent 21b739f commit 77dee25efd2fb114a56e83a165a97fef22c68316
Showing with 1 addition and 1 deletion.
  1. +1 −1 benchmark/dns/lookup.js
@@ -4,7 +4,7 @@ const common = require('../common.js');
const lookup = require('dns').lookup;

const bench = common.createBenchmark(main, {
name: ['', '127.0.0.1', '::1'],
name: ['127.0.0.1', '::1'],
all: ['true', 'false'],
n: [5e6]
});

0 comments on commit 77dee25

Please sign in to comment.
You can’t perform that action at this time.