Please sign in to comment.
crypto: remove root_cert_store from node_crypto.h
root_cert_store is defined as extern in node_crypto.h but only used in node_crypto.cc. It is then set using SSL_CTX_set_cert_store. The only usages of SSL_CTX_get_cert_store are in node_crypto.cc which would all be accessing the same X509_STORE through the root_cert_store pointer as far as I can tell. Am I missing something here? This commit suggests removing it from the header and making it static in node_crypto.cc. PR-URL: #13194 Reviewed-By: Colin Ihrig <firstname.lastname@example.org> Reviewed-By: Ben Noordhuis <email@example.com> Reviewed-By: Michael Dawson <firstname.lastname@example.org> Reviewed-By: James M Snell <email@example.com> Reviewed-By: Sam Roberts <firstname.lastname@example.org>
- Loading branch information...
Showing with 3 additions and 5 deletions.