Skip to content
Permalink
Browse files

tools: replace custom new-with-error rule

Use no-restricted-syntax to implement the requirement that `Error`
objects must be thrown with the `new` keyword.

PR-URL: #12249
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
  • Loading branch information...
Trott committed Apr 6, 2017
1 parent a37273c commit 8191af5b292aa5d5f07492105781b6cf1d91c42f
Showing with 5 additions and 34 deletions.
  1. +5 −3 .eslintrc.yaml
  2. +0 −31 tools/eslint-rules/new-with-error.js
@@ -106,8 +106,11 @@ rules:
message: "setTimeout() must be invoked with at least two arguments."
}, {
selector: "CallExpression[callee.name='setInterval'][arguments.length<2]",
message: "setInterval() must be invoked with at least 2 arguments"
}]
message: "setInterval() must be invoked with at least 2 arguments."
}, {
selector: "ThrowStatement > CallExpression[callee.name=/Error$/]",
message: "Use new keyword when throwing an Error."
}]
no-tabs: 2
no-trailing-spaces: 2
one-var-declaration-per-line: 2
@@ -141,7 +144,6 @@ rules:
align-multiline-assignment: 2
assert-fail-single-argument: 2
assert-throws-arguments: [2, { requireTwo: false }]
new-with-error: [2, Error, RangeError, TypeError, SyntaxError, ReferenceError]
no-unescaped-regexp-dot: 2

# Global scoped method and vars

This file was deleted.

0 comments on commit 8191af5

Please sign in to comment.
You can’t perform that action at this time.