Permalink
Browse files

http: should support userland Agent

PR-URL: #11567
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  • Loading branch information...
fengmk2 authored and jasnell committed Feb 26, 2017
1 parent 20b1823 commit 90403dd1d06d01ca69aea810bcaa7f41b031e8b4
Showing with 3 additions and 3 deletions.
  1. +2 −2 lib/_http_client.js
  2. +1 −1 test/parallel/test-http-client-reject-unexpected-agent.js
View
@@ -89,9 +89,9 @@ function ClientRequest(options, cb) {
}
// Explicitly pass through this statement as agent will not be used
// when createConnection is provided.
} else if (!(agent instanceof Agent.Agent)) {
} else if (typeof agent.addRequest !== 'function') {
throw new TypeError(
'Agent option must be an instance of http.Agent, undefined or false.'
'Agent option must be an Agent-like object, undefined, or false.'
);
}
this.agent = agent;
@@ -49,7 +49,7 @@ server.listen(0, baseOptions.host, common.mustCall(function() {
failingAgentOptions.forEach((agent) => {
assert.throws(
() => createRequest(agent),
/^TypeError: Agent option must be an instance of http.Agent/,
/^TypeError: Agent option must be an Agent-like object/,
`Expected typeof agent: ${typeof agent} to be rejected`
);
});

0 comments on commit 90403dd

Please sign in to comment.