Permalink
Browse files

test: make test-tls-connect checks more strict

Check the error code on expected errors so that the introduction of
different errors in refactoring is caught.

While at it, re-order modules alphabetically per test-writing guide.

PR-URL: #14695
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  • Loading branch information...
Trott authored and MylesBorins committed Aug 8, 2017
1 parent 9ed2c4c commit 91649b913c4beb730fbb3f4e2035f9cf1f60b18e
Showing with 10 additions and 4 deletions.
  1. +10 −4 test/parallel/test-tls-connect.js
@@ -1,13 +1,13 @@
'use strict';
const common = require('../common');
const assert = require('assert');
if (!common.hasCrypto)
common.skip('missing crypto');
const tls = require('tls');
const assert = require('assert');
const fs = require('fs');
const path = require('path');
const tls = require('tls');
// https://github.com/joyent/node/issues/1218
// uncatchable exception on TLS connection error
@@ -18,7 +18,10 @@ const path = require('path');
const options = {cert: cert, key: key, port: common.PORT};
const conn = tls.connect(options, common.fail);
conn.on('error', common.mustCall());
conn.on(
'error',
common.mustCall((e) => { assert.strictEqual(e.code, 'ECONNREFUSED'); })
);
}
// SSL_accept/SSL_connect error handling
@@ -35,5 +38,8 @@ const path = require('path');
assert.ok(false); // callback should never be executed
});
conn.on('error', common.mustCall());
conn.on(
'error',
common.mustCall((e) => { assert.strictEqual(e.code, 'ECONNREFUSED'); })
);
}

0 comments on commit 91649b9

Please sign in to comment.