Permalink
Browse files

test: refactor test-file-write-stream

Replace all `var` occurrences in test-file-write-stream.js with
`const` (where they are not being reassigned) and `let` (where they are
being reassigned).

Add strict comparison to the asserts and if statements:

  - Replace `assert.equal` with `assert.strictEqual` where:
    1. Result of `typeof` being compared to a string literal.
    2. Result of `fs.readFileSync` with UTF-8 encoding being compared to
       a string constant.

  - Replace `==` with `===` where integer values are being compared to
    integer literals.

Remove unnecessary very IIFE.

Use template literals.

PR-URL: #8894
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  • Loading branch information...
sudaraka authored and Fishrock123 committed Oct 2, 2016
1 parent 5164865 commit 93c48743f17023ab608c2e4f4c210abcb6f46812
Showing with 17 additions and 19 deletions.
  1. +17 −19 test/parallel/test-file-write-stream.js
@@ -1,18 +1,18 @@
'use strict';
var common = require('../common');
var assert = require('assert');
const common = require('../common');
const assert = require('assert');
var path = require('path');
var fs = require('fs');
var fn = path.join(common.tmpDir, 'write.txt');
const path = require('path');
const fs = require('fs');
const fn = path.join(common.tmpDir, 'write.txt');
common.refreshTmpDir();
var file = fs.createWriteStream(fn, {
const file = fs.createWriteStream(fn, {
highWaterMark: 10
});
var EXPECTED = '012345678910';
const EXPECTED = '012345678910';
var callbacks = {
const callbacks = {
open: -1,
drain: -2,
close: -1
@@ -22,19 +22,19 @@ file
.on('open', function(fd) {
console.error('open!');
callbacks.open++;
assert.equal('number', typeof fd);
assert.strictEqual('number', typeof fd);
})
.on('error', function(err) {
throw err;
})
.on('drain', function() {
console.error('drain!', callbacks.drain);
callbacks.drain++;
if (callbacks.drain == -1) {
assert.equal(EXPECTED, fs.readFileSync(fn, 'utf8'));
if (callbacks.drain === -1) {
assert.strictEqual(EXPECTED, fs.readFileSync(fn, 'utf8'));
file.write(EXPECTED);
} else if (callbacks.drain == 0) {
assert.equal(EXPECTED + EXPECTED, fs.readFileSync(fn, 'utf8'));
} else if (callbacks.drain === 0) {
assert.strictEqual(EXPECTED + EXPECTED, fs.readFileSync(fn, 'utf8'));
file.end();
}
})
@@ -51,15 +51,13 @@ file
fs.unlinkSync(fn);
});
for (var i = 0; i < 11; i++) {
(function(i) {
file.write('' + i);
})(i);
for (let i = 0; i < 11; i++) {
file.write(`${i}`);
}
process.on('exit', function() {
for (var k in callbacks) {
assert.equal(0, callbacks[k], k + ' count off by ' + callbacks[k]);
for (const k in callbacks) {
assert.strictEqual(0, callbacks[k], `${k} count off by ${callbacks[k]}`);
}
console.log('ok');
});

0 comments on commit 93c4874

Please sign in to comment.