Skip to content

Commit

Permalink
test: check inspector support in test/inspector
Browse files Browse the repository at this point in the history
When configuring node --without-ssl or --without-inspector these test
will fail. The underlying issue will be:

Inspector support is not available with this Node.js build
/work/nodejs/node/out/Release/node: bad option: --inspect=0

This commit adds checks to see if inspector support is enabled and if
not skips these tests.

PR-URL: #13324
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@chromium.org>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
danbev authored and jasnell committed Jun 5, 2017
1 parent 47c9de9 commit 93e91a4
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
1 change: 1 addition & 0 deletions test/inspector/test-inspector-port-zero-cluster.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
'use strict';

const common = require('../common');
common.skipIfInspectorDisabled();
const assert = require('assert');
const cluster = require('cluster');

Expand Down
3 changes: 2 additions & 1 deletion test/inspector/test-inspector-port-zero.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
'use strict';

const { mustCall } = require('../common');
const { mustCall, skipIfInspectorDisabled } = require('../common');
skipIfInspectorDisabled();
const assert = require('assert');
const { URL } = require('url');
const { spawn } = require('child_process');
Expand Down

0 comments on commit 93e91a4

Please sign in to comment.