Permalink
Browse files

async_wrap: close the destroy_ids_idle_handle_

The destroy_ids_idle_handle_ needs to be closed on
environment destruction. Not closing the handle leaves
a dangling pointer in the used uv loop. This leads to
undefined behavior when the uv loop is used after the
environment has been destroyed.

PR-URL: #10385
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information...
reshnm authored and italoacasas committed Dec 21, 2016
1 parent 1253650 commit 94c4323d56c1f05b389d5aec7a8dab3e76d89a10
Showing with 13 additions and 0 deletions.
  1. +13 −0 src/env-inl.h
View
@@ -207,6 +207,19 @@ inline Environment::~Environment() {
delete hc;
}
while (handle_cleanup_waiting_ != 0)
uv_run(event_loop(), UV_RUN_ONCE);
// Closing the destroy_ids_idle_handle_ within the handle cleanup queue
// prevents the async wrap destroy hook from being called.
uv_handle_t* handle =
reinterpret_cast<uv_handle_t*>(&destroy_ids_idle_handle_);
handle->data = this;
handle_cleanup_waiting_ = 1;
uv_close(handle, [](uv_handle_t* handle) {
static_cast<Environment*>(handle->data)->FinishHandleCleanup(handle);
});
while (handle_cleanup_waiting_ != 0)
uv_run(event_loop(), UV_RUN_ONCE);

0 comments on commit 94c4323

Please sign in to comment.