Skip to content

Commit 94e2b5c

Browse files
Trottjasnell
authored andcommitted
test: refactor test-debug-prompt
* Use cleaner `process.stdin.write('.exit')` to exit the process rather than `proc.kill()`. * Move test to sequential. It uses the default port 9229. It will fail if another inspector test (or test using port 0) is already using that port. So it needs to be run sequentially rather than in parallel with other tests. (We haven't seen many failures with it yet because there aren't a lot of other inspector tests in parallel at this time.) PR-URL: #15141 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 5881033 commit 94e2b5c

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

test/parallel/test-debug-prompt.js renamed to test/sequential/test-debug-prompt.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,5 +11,5 @@ let output = '';
1111
proc.stdout.on('data', (data) => {
1212
output += data;
1313
if (output.includes('debug> '))
14-
proc.kill();
14+
proc.stdin.write('.exit\n');
1515
});

0 commit comments

Comments
 (0)