Skip to content

Commit a89deb9

Browse files
sejokerFishrock123
authored andcommitted
test: cleanup test-c-ares.js
Replace equal with strictEqual, use const instead of var Replace throw error with assert.ifError PR-URL: #8577 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
1 parent 9c3d521 commit a89deb9

File tree

1 file changed

+18
-18
lines changed

1 file changed

+18
-18
lines changed

test/parallel/test-c-ares.js

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,26 @@
11
'use strict';
2-
var common = require('../common');
3-
var assert = require('assert');
2+
const common = require('../common');
3+
const assert = require('assert');
44

5-
var dns = require('dns');
5+
const dns = require('dns');
66

77

88
// Try resolution without callback
99

10-
dns.lookup(null, function(error, result, addressType) {
11-
assert.equal(null, result);
12-
assert.equal(4, addressType);
13-
});
10+
dns.lookup(null, common.mustCall(function(error, result, addressType) {
11+
assert.strictEqual(null, result);
12+
assert.strictEqual(4, addressType);
13+
}));
1414

15-
dns.lookup('127.0.0.1', function(error, result, addressType) {
16-
assert.equal('127.0.0.1', result);
17-
assert.equal(4, addressType);
18-
});
15+
dns.lookup('127.0.0.1', common.mustCall(function(error, result, addressType) {
16+
assert.strictEqual('127.0.0.1', result);
17+
assert.strictEqual(4, addressType);
18+
}));
1919

20-
dns.lookup('::1', function(error, result, addressType) {
21-
assert.equal('::1', result);
22-
assert.equal(6, addressType);
23-
});
20+
dns.lookup('::1', common.mustCall(function(error, result, addressType) {
21+
assert.strictEqual('::1', result);
22+
assert.strictEqual(6, addressType);
23+
}));
2424

2525
// Try calling resolve with an unsupported type.
2626
assert.throws(function() {
@@ -36,8 +36,8 @@ assert.throws(function() {
3636
// C:\Windows\System32\drivers\etc\hosts
3737
// so we disable this test on Windows.
3838
if (!common.isWindows) {
39-
dns.reverse('127.0.0.1', function(error, domains) {
40-
if (error) throw error;
39+
dns.reverse('127.0.0.1', common.mustCall(function(error, domains) {
40+
assert.ifError(error);
4141
assert.ok(Array.isArray(domains));
42-
});
42+
}));
4343
}

0 commit comments

Comments
 (0)