Permalink
Browse files

test: enable marking of failing coverage tests

Enable marking of coverage tests so that we can
allow some tests to fail without blocking the generation
of coverage data. This will later allow us to
fail the coverage job if other kinds of errors occur and
to capture which tests we believe are not running properly
with coverage enabled.

PR-URL: #25671
Reviewed-By: Ben Coe <bencoe@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Refael Ackermann <refack@gmail.com>
  • Loading branch information...
mhdawson authored and targos committed Jan 22, 2019
1 parent f3179f7 commit af6e439ad806f2032e0dc5f84b37703e76b9f31e
Showing with 8 additions and 3 deletions.
  1. +3 −2 Makefile
  2. +4 −0 test/root.status
  3. +1 −1 tools/test.py
@@ -226,7 +226,8 @@ coverage-test: coverage-build
$(RM) out/$(BUILDTYPE)/obj.target/node_lib/gen/*.gcda
$(RM) out/$(BUILDTYPE)/obj.target/node_lib/src/*.gcda
$(RM) out/$(BUILDTYPE)/obj.target/node_lib/src/tracing/*.gcda
-NODE_V8_COVERAGE=out/$(BUILDTYPE)/.coverage $(MAKE) $(COVTESTS)
-NODE_V8_COVERAGE=out/$(BUILDTYPE)/.coverage \
TEST_CI_ARGS="$(TEST_CI_ARGS) --type=coverage" $(MAKE) $(COVTESTS)
$(MAKE) coverage-report-js
-(cd out && "../gcovr/scripts/gcovr" --gcov-exclude='.*deps' \
--gcov-exclude='.*usr' -v -r Release/obj.target \
@@ -277,7 +278,7 @@ coverage-run-js:
$(RM) -r out/$(BUILDTYPE)/.coverage
$(MAKE) coverage-build-js
-NODE_V8_COVERAGE=out/$(BUILDTYPE)/.coverage CI_SKIP_TESTS=$(COV_SKIP_TESTS) \
$(MAKE) jstest
TEST_CI_ARGS="$(TEST_CI_ARGS) --type=coverage" $(MAKE) jstest
$(MAKE) coverage-report-js

.PHONY: test
@@ -159,3 +159,7 @@ sequential/test-inspector-port-cluster: SLOW
sequential/test-net-bytes-per-incoming-chunk-overhead: SLOW
sequential/test-pipe: SLOW
sequential/test-util-debug: SLOW

[$type==coverage]
js-native-api/test_function/test: PASS,FAIL,CRASH
js-native-api/test_general/testFinalizer: PASS,FAIL,CRASH
@@ -1391,7 +1391,7 @@ def BuildOptions():
help='Send SIGABRT instead of SIGTERM to kill processes that time out',
default=False, action="store_true", dest="abort_on_timeout")
result.add_option("--type",
help="Type of build (simple, fips)",
help="Type of build (simple, fips, coverage)",
default=None)
return result

0 comments on commit af6e439

Please sign in to comment.