|
1 |
| -### Pull Request check-list |
| 1 | +<!-- |
| 2 | +Thank you for submitting a pull request to Node.js. Before you submit, please |
| 3 | +review below requirements and walk through the checklist. You can 'tick' |
| 4 | +a box by using the letter "x": [x]. |
2 | 5 |
|
3 |
| -_Please make sure to review and check all of these items:_ |
| 6 | +Run the test suite by invoking: `make -j4 lint test` on linux or |
| 7 | +`vcbuild test nosign` on Windows. |
4 | 8 |
|
5 |
| -- [ ] Does `make -j8 test` (UNIX) or `vcbuild test nosign` (Windows) pass with |
6 |
| - this change (including linting)? |
7 |
| -- [ ] Is the commit message formatted according to [CONTRIBUTING.md][0]? |
8 |
| -- [ ] If this change fixes a bug (or a performance problem), is a regression |
9 |
| - test (or a benchmark) included? |
10 |
| -- [ ] Is a documentation update included (if this change modifies |
11 |
| - existing APIs, or introduces new ones)? |
| 9 | +If this aims to fix a regression or you’re adding a feature, make sure you also |
| 10 | +write a test. Finally – if possible – a benchmark that quantifies your changes. |
12 | 11 |
|
13 |
| -_NOTE: these things are not required to open a PR and can be done |
14 |
| -afterwards / while the PR is open._ |
| 12 | +Finally, read through our contributors guide and make adjustments as necessary: |
| 13 | +https://github.com/nodejs/node/blob/master/CONTRIBUTING.md |
| 14 | +--> |
15 | 15 |
|
16 |
| -### Affected core subsystem(s) |
| 16 | +##### Checklist |
17 | 17 |
|
18 |
| -_Please provide affected core subsystem(s) (like buffer, cluster, crypto, etc)_ |
| 18 | +<!-- remove lines that do not apply to you --> |
19 | 19 |
|
20 |
| -[0]: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#step-3-commit |
| 20 | +- [ ] tests and code linting passes |
| 21 | +- [ ] a test and/or benchmark is included |
| 22 | +- [ ] documentation is changed or added |
| 23 | +- [ ] the commit message follows commit guidelines |
21 | 24 |
|
22 |
| -### Description of change |
23 | 25 |
|
24 |
| -_Please provide a description of the change here._ |
| 26 | +##### Affected core subsystem(s) |
| 27 | + |
| 28 | +<!-- provide affected core subsystem(s) (like doc, cluster, crypto, etc) --> |
| 29 | + |
| 30 | + |
| 31 | +##### Description of change |
| 32 | + |
| 33 | +<!-- provide a description of the change below this comment --> |
0 commit comments