Skip to content
Permalink
Browse files
benchmark: fix http2 benchmarks
Fixes: #36746

PR-URL: #36871
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
  • Loading branch information
Trott authored and targos committed May 1, 2021
1 parent 5770ae0 commit c22efc519116e8ddc2167b903b3705a78a4f4611
@@ -46,7 +46,7 @@ function run() {
}
} else { // HTTP/2
const client = http.connect(url);
client.on('error', (e) => { throw e; });
client.on('error', () => {});
request(client.request(), client);
}
}
@@ -24,9 +24,10 @@ function main({ requests, streams, clients, duration }) {
res.destroy();
});
});
server.listen(common.PORT, () => {
server.listen(0, () => {
bench.http({
path: '/',
port: server.address().port,
requests,
maxConcurrentStreams: streams,
clients,
@@ -1,7 +1,6 @@
'use strict';

const common = require('../common.js');
const PORT = common.PORT;

const bench = common.createBenchmark(main, {
n: [1e3],
@@ -32,8 +31,8 @@ function main({ n, nheaders }) {
stream.respond();
stream.end('Hi!');
});
server.listen(PORT, () => {
const client = http2.connect(`http://localhost:${PORT}/`, {
server.listen(0, () => {
const client = http2.connect(`http://localhost:${server.address().port}/`, {
maxHeaderListPairs: 20000
});

@@ -25,10 +25,11 @@ function main({ requests, streams, clients, duration }) {
stream.respondWithFD(fd);
stream.on('error', (err) => {});
});
server.listen(common.PORT, () => {
server.listen(0, () => {
bench.http({
path: '/',
requests,
port: server.address().port,
maxConcurrentStreams: streams,
clients,
duration,
@@ -22,9 +22,10 @@ function main({ requests, streams, clients, duration }) {
out.pipe(stream);
stream.on('error', (err) => {});
});
server.listen(common.PORT, () => {
server.listen(0, () => {
bench.http({
path: '/',
port: server.address().port,
requests,
maxConcurrentStreams: streams,
clients,
@@ -26,9 +26,10 @@ function main({ streams, length, size, duration }) {
}
write();
});
server.listen(common.PORT, () => {
server.listen(0, () => {
bench.http({
path: '/',
port: server.address().port,
requests: 10000,
duration,
maxConcurrentStreams: streams,

0 comments on commit c22efc5

Please sign in to comment.