Skip to content
Permalink
Browse files

test: check noop function invocations

In test/pummel/test-stream2-basic.js, check that noop functions are
called the expected number of times.

PR-URL: #13146
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  • Loading branch information...
Trott authored and jasnell committed May 21, 2017
1 parent db90b50 commit cd70a520d2d931871e5b6abd1ac21fb797f0a40f
Showing with 13 additions and 13 deletions.
  1. +13 −13 test/pummel/test-stream2-basic.js
@@ -147,7 +147,7 @@ test('a most basic test', function(t) {
'xxxxxxxxxxxxxxxxxxxxx' ];

r.on('end', function() {
t.same(reads, expect);
assert.strict(reads, expect);
t.end();
});

@@ -180,7 +180,7 @@ test('pipe', function(t) {
const w = new TestWriter();

w.on('end', function(received) {
t.same(received, expect);
assert.strict(received, expect);
t.end();
});

@@ -226,15 +226,15 @@ test('pipe', function(t) {
t.equal(ended0, false);
ended0 = true;
ended++;
t.same(results, expect[0]);
assert.strict(results, expect[0]);
});

w[1].on('end', function(results) {
t.equal(ended1, false);
ended1 = true;
ended++;
t.equal(ended, 2);
t.same(results, expect[1]);
assert.strict(results, expect[1]);
t.end();
});

@@ -261,11 +261,11 @@ test('multipipe', function(t) {

let c = 2;
w[0].on('end', function(received) {
t.same(received, expect, 'first');
assert.strict(received, expect, 'first');
if (--c === 0) t.end();
});
w[1].on('end', function(received) {
t.same(received, expect, 'second');
assert.strict(received, expect, 'second');
if (--c === 0) t.end();
});

@@ -306,13 +306,13 @@ test('multipipe', function(t) {

w[0].on('end', function(results) {
ended++;
t.same(results, expect[0]);
assert.strict(results, expect[0]);
});

w[1].on('end', function(results) {
ended++;
t.equal(ended, 2);
t.same(results, expect[1]);
assert.strict(results, expect[1]);
t.end();
});

@@ -323,7 +323,7 @@ test('multipipe', function(t) {

test('back pressure respected', function(t) {
const r = new R({ objectMode: true });
r._read = common.noop;
r._read = common.mustNotCall();
let counter = 0;
r.push(['one']);
r.push(['two']);
@@ -341,7 +341,7 @@ test('back pressure respected', function(t) {
r.pipe(w3);
});
};
w1.end = common.noop;
w1.end = common.mustNotCall();

r.pipe(w1);

@@ -367,7 +367,7 @@ test('back pressure respected', function(t) {

return false;
};
w2.end = common.noop;
w2.end = common.mustCall();

const w3 = new R();
w3.write = function(chunk) {
@@ -400,7 +400,7 @@ test('read(0) for ended streams', function(t) {
const r = new R();
let written = false;
let ended = false;
r._read = common.noop;
r._read = common.mustNotCall();

r.push(Buffer.from('foo'));
r.push(null);
@@ -471,7 +471,7 @@ test('adding readable triggers data flow', function(t) {

test('chainable', function(t) {
const r = new R();
r._read = common.noop;
r._read = common.mustCall();
const r2 = r.setEncoding('utf8').pause().resume().pause();
t.equal(r, r2);
t.end();

0 comments on commit cd70a52

Please sign in to comment.
You can’t perform that action at this time.