Skip to content
Permalink
Browse files

module: prioritize current dir for local lookups

This fixes a bug where a 3rd party module found in node_modules,
would be preferred over a ./local module with the same name.

Fixes: #5684
PR-URL: #5689
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
  • Loading branch information...
phillipj committed Mar 13, 2016
1 parent ccd8188 commit d38503ab01c607ca55b4816e2c249411a3f10269
Showing with 11 additions and 2 deletions.
  1. +1 −2 lib/module.js
  2. +10 −0 test/parallel/test-module-relative-lookup.js
@@ -250,8 +250,7 @@ Module._resolveLookupPaths = function(request, parent) {
if (!parent || !parent.id || !parent.filename) {
// make require('./path/to/foo') work - normally the path is taken
// from realpath(__filename) but with eval there is no filename
var mainPaths = ['.'].concat(modulePaths);
mainPaths = Module._nodeModulePaths('.').concat(mainPaths);
var mainPaths = ['.'].concat(Module._nodeModulePaths('.'), modulePaths);
return [request, mainPaths];
}

@@ -0,0 +1,10 @@
'use strict';

require('../common');
const assert = require('assert');
const _module = require('module'); // avoid collision with global.module
const lookupResults = _module._resolveLookupPaths('./lodash');
const paths = lookupResults[1];

assert.strictEqual(paths[0], '.',
'Current directory is prioritized before node_modules for local modules');

0 comments on commit d38503a

Please sign in to comment.
You can’t perform that action at this time.