Skip to content

Commit

Permalink
tools: pass constant to logger instead of string
Browse files Browse the repository at this point in the history
On a few of our installations (namely CentOS), passing 'INFO'
resulted in a silent loglevel. Use a logging constant instead.

Cherry-picked from 8606793
Original commit metadata follows:
  Fixes: nodejs/build#104
  PR-URL: #1842
  Reviewed-By: Rod Vagg <rod@vagg.org>

PR-URL: nodejs/node-v0.x-archive#25686
Reviewed-By: Julien Gilli <julien.gilli@joyent.com>
  • Loading branch information
jbergstroem authored and orangemocha committed Jul 17, 2015
1 parent c283c9b commit df59d43
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tools/test.py
Original file line number Diff line number Diff line change
Expand Up @@ -1368,7 +1368,7 @@ def Main():

ch = logging.StreamHandler(sys.stdout)
logger.addHandler(ch)
logger.setLevel('INFO')
logger.setLevel(logging.INFO)
if options.logfile:
fh = logging.FileHandler(options.logfile)
logger.addHandler(fh)
Expand Down

0 comments on commit df59d43

Please sign in to comment.