Skip to content

Commit

Permalink
doc: create list for commonly edited files in PRs
Browse files Browse the repository at this point in the history
PR-URL: #19776
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
trivikr committed Apr 6, 2018
1 parent 682b850 commit f02e4b9
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions doc/guides/contributing/pull-requests.md
Original file line number Diff line number Diff line change
Expand Up @@ -101,9 +101,11 @@ $ git checkout -b my-branch -t upstream/master
### Step 3: Code

The vast majority of Pull Requests opened against the `nodejs/node`
repository includes changes to either the C/C++ code contained in the `src`
directory, the JavaScript code contained in the `lib` directory, the
documentation in `docs/api` or tests within the `test` directory.
repository includes changes to one or more of the following:
- the C/C++ code contained in the `src` directory
- the JavaScript code contained in the `lib` directory
- the documentation in `doc/api`
- tests within the `test` directory.

If you are modifying code, please be sure to run `make lint` from time to
time to ensure that the changes follow the Node.js code style guide.
Expand Down

0 comments on commit f02e4b9

Please sign in to comment.