url: make urlToOptions() handle IPv6 literals

Strip the enclosing square brackets from the parsed hostname. PR-URL: #19720 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
nodejs · Apr 10, 2018 · fa2d43b · fa2d43b
1 parent d1156da
commit fa2d43b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/lib/internal/url.js b/lib/internal/url.js
@@ -1314,7 +1314,9 @@ function domainToUnicode(domain) {
 function urlToOptions(url) {
   var options = {
     protocol: url.protocol,
-    hostname: url.hostname,
+    hostname: url.hostname.startsWith('[') ?
+      url.hostname.slice(1, -1) :
+      url.hostname,
     hash: url.hash,
     search: url.search,
     pathname: url.pathname,

diff --git a/test/parallel/test-whatwg-url-properties.js b/test/parallel/test-whatwg-url-properties.js
@@ -143,6 +143,9 @@ assert.strictEqual(url.searchParams, oldParams);
   assert.strictEqual(opts.pathname, '/aaa/zzz');
   assert.strictEqual(opts.search, '?l=24');
   assert.strictEqual(opts.hash, '#test');
+
+  const { hostname } = urlToOptions(new URL('http://[::1]:21'));
+  assert.strictEqual(hostname, '::1');
 }
 
 // Test special origins