Skip to content
Permalink
Browse files

src: only call FatalException if not verbose

This commit attempts to address the TODO regarding not calling
FatalException if the try_catch is verbose.

PR-URL: #12826
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
  • Loading branch information...
danbev committed May 3, 2017
1 parent 986e1d2 commit fefab9026b4dac57de30f81dd39b9c2f20a3ada8
Showing with 3 additions and 3 deletions.
  1. +3 −3 src/node.cc
@@ -2648,9 +2648,9 @@ void FatalException(Isolate* isolate,

void FatalException(Isolate* isolate, const TryCatch& try_catch) {
HandleScope scope(isolate);
// TODO(bajtos) do not call FatalException if try_catch is verbose
// (requires V8 API to expose getter for try_catch.is_verbose_)
FatalException(isolate, try_catch.Exception(), try_catch.Message());
if (!try_catch.IsVerbose()) {
FatalException(isolate, try_catch.Exception(), try_catch.Message());
}
}


0 comments on commit fefab90

Please sign in to comment.
You can’t perform that action at this time.