Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable building with shared uvwasi library. #35339

Closed
dilyanpalauzov opened this issue Sep 25, 2020 · 3 comments
Closed

Enable building with shared uvwasi library. #35339

dilyanpalauzov opened this issue Sep 25, 2020 · 3 comments
Labels
build Issues and PRs related to build files or the CI. feature request Issues that request new features to be added to Node.js. stale

Comments

@dilyanpalauzov
Copy link

Nodejs depends on uvwasi, libuv, brotli. It can be build to use the shared-libraries for libuv, ICU, brotli, c-ares.

  • Enable building with shared uvwasi library.
@bnoordhuis bnoordhuis added build Issues and PRs related to build files or the CI. feature request Issues that request new features to be added to Node.js. labels Sep 25, 2020
@bnoordhuis
Copy link
Member

Pull request welcome.

@PoojaDurgad PoojaDurgad mentioned this issue Nov 25, 2020
Closed
4 tasks
PoojaDurgad added a commit to PoojaDurgad/node that referenced this issue Nov 27, 2020
@PoojaDurgad
build: enable building with shared uvwasi lib
e9f38a3 
Fixes: nodejs#35339
@github-actions
Copy link
Contributor

There has been no activity on this feature request for 5 months and it is unlikely to be implemented. It will be closed 6 months after the last non-automated comment.

For more information on how the project manages feature requests, please consult the feature request management document.

@github-actions github-actions bot added the stale label Mar 18, 2022
@targos targos moved this from Pending Triage to Stale in Node.js feature requests Mar 19, 2022
@targos targos moved this to Pending Triage in Node.js feature requests Mar 19, 2022
@github-actions
Copy link
Contributor

There has been no activity on this feature request and it is being closed. If you feel closing this issue is not the right thing to do, please leave a comment.

For more information on how the project manages feature requests, please consult the feature request management document.

@richardlau richardlau mentioned this issue Jul 25, 2022
Closed
aduh95 added a commit that referenced this issue May 12, 2024
@PoojaDurgad @Teutates @aduh95
build: enable building with shared uvwasi lib
49e2c69 
Fixes: #35339
Co-authored-by: Pooja D P <Pooja.D.P@ibm.com>
Co-authored-by: Teutates <103068388+Teutates@users.noreply.github.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #43987
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this issue May 12, 2024
@PoojaDurgad @Teutates
@aduh95 @targos
build: enable building with shared uvwasi lib
f96466a 
Fixes: #35339
Co-authored-by: Pooja D P <Pooja.D.P@ibm.com>
Co-authored-by: Teutates <103068388+Teutates@users.noreply.github.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #43987
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
eliphazbouye pushed a commit to eliphazbouye/node that referenced this issue Jun 20, 2024
@PoojaDurgad @Teutates
@aduh95 @eliphazbouye
build: enable building with shared uvwasi lib
4f3da76 
Fixes: nodejs#35339
Co-authored-by: Pooja D P <Pooja.D.P@ibm.com>
Co-authored-by: Teutates <103068388+Teutates@users.noreply.github.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: nodejs#43987
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
bmeck pushed a commit to bmeck/node that referenced this issue Jun 22, 2024
@PoojaDurgad @Teutates
@aduh95 @bmeck
build: enable building with shared uvwasi lib
24fa553 
Fixes: nodejs#35339
Co-authored-by: Pooja D P <Pooja.D.P@ibm.com>
Co-authored-by: Teutates <103068388+Teutates@users.noreply.github.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: nodejs#43987
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this issue Sep 21, 2024
@PoojaDurgad @Teutates
@aduh95 @targos
build: enable building with shared uvwasi lib
eb2402d 
Fixes: #35339
Co-authored-by: Pooja D P <Pooja.D.P@ibm.com>
Co-authored-by: Teutates <103068388+Teutates@users.noreply.github.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #43987
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. feature request Issues that request new features to be added to Node.js. stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: enable building with shared uvwasi lib PoojaDurgad/node
2 participants
@bnoordhuis @dilyanpalauzov