-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test-worker-heap-snapshot crash #44515
Labels
flaky-test
Issues and PRs related to the tests with unstable failures on the CI.
windows
Issues and PRs related to the Windows platform.
Comments
ywave620
added
the
flaky-test
Issues and PRs related to the tests with unstable failures on the CI.
label
Sep 5, 2022
github-actions
bot
added
the
windows
Issues and PRs related to the Windows platform.
label
Sep 5, 2022
Truncated stack trace from an old report: nodejs/reliability#338
|
nodejs-github-bot
pushed a commit
that referenced
this issue
Oct 6, 2022
Any WorkerHeapSnapshotTaker instance should be fully owned by main thread. Remove buggy access to it from the worker thread. PR-URL: #44745 Fixes: #44515 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
danielleadams
pushed a commit
that referenced
this issue
Oct 11, 2022
Any WorkerHeapSnapshotTaker instance should be fully owned by main thread. Remove buggy access to it from the worker thread. PR-URL: #44745 Fixes: #44515 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
flaky-test
Issues and PRs related to the tests with unstable failures on the CI.
windows
Issues and PRs related to the Windows platform.
Test
test-worker-heap-snapshot
Platform
win2012r2-COMPILED_BY-vs2019-x86
Console output
Build links
Additional information
failed on CI of this PR: #44434
The test failed on another CI, either: #39686
The text was updated successfully, but these errors were encountered: