Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: documentation for WriteStream.cursorTo and other TTY methods #9853

Closed
dcposch opened this issue Nov 30, 2016 · 5 comments
Closed

doc: documentation for WriteStream.cursorTo and other TTY methods #9853

dcposch opened this issue Nov 30, 2016 · 5 comments
Labels
doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors. tty Issues and PRs related to the tty subsystem.

Comments

@dcposch
Copy link
Contributor

dcposch commented Nov 30, 2016

Even if they're deprecated and we're supposed to use the readline module now, the docs should say that, right?

Currently, the docs don't list process.stdout.cursorTo and related functions at all.

Popular modules, as well as Node itself, still use them:

node-progress module
node debugger

Here's the full list of functions I'm referring to:

tty.js:92

I think it would reduce confusion if we at least mentioned these in the process or stream docs.

@dcposch
Copy link
Contributor Author

dcposch commented Nov 30, 2016

Old issue

nodejs/node-v0.x-archive#6933 (comment)

@mscdex mscdex added doc Issues and PRs related to the documentations. tty Issues and PRs related to the tty subsystem. labels Nov 30, 2016
@Fishrock123
Copy link
Contributor

Fishrock123 commented Nov 30, 2016

I think we should be able to issue runtime deprecations for these. There shouldn't be a reason to document them.

@dcposch
Copy link
Contributor Author

dcposch commented Nov 30, 2016

We should at least remove our own use of WriteStream.cursorTo first:

node ebugger _debugger.js:865

@Trott
Copy link
Member

Trott commented Jul 15, 2017

@dcposch @Fishrock123 Should this remain open?

@Trott
Copy link
Member

Trott commented Aug 16, 2018

@nodejs/documentation @nodejs/process Anyone want to document cursorTo(), maybe while adding a doc-only deprecation?

@Trott Trott added the good first issue Issues that are suitable for first-time contributors. label Aug 16, 2018
ur0 added a commit to ur0/node that referenced this issue Sep 17, 2018
Adds documentation for the following WriteStream instance methods:
- cursorTo
- moveCursor
- clearLine
- clearScreenDown
- getWindowSize

Fixes nodejs#9853.
targos pushed a commit that referenced this issue Oct 6, 2018
Adds documentation for the following `WriteStream` instance methods:

- `WriteStream.clearLine()`
- `WriteStream.clearScreenDown()`
- `WriteStream.cursorTo()`
- `WriteStream.getWindowSize()`
- `WriteStream.moveCursor()`

PR-URL: #22893
Fixes: #9853
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
targos pushed a commit that referenced this issue Oct 7, 2018
Adds documentation for the following `WriteStream` instance methods:

- `WriteStream.clearLine()`
- `WriteStream.clearScreenDown()`
- `WriteStream.cursorTo()`
- `WriteStream.getWindowSize()`
- `WriteStream.moveCursor()`

PR-URL: #22893
Fixes: #9853
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
jasnell pushed a commit that referenced this issue Oct 17, 2018
Adds documentation for the following `WriteStream` instance methods:

- `WriteStream.clearLine()`
- `WriteStream.clearScreenDown()`
- `WriteStream.cursorTo()`
- `WriteStream.getWindowSize()`
- `WriteStream.moveCursor()`

PR-URL: #22893
Fixes: #9853
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors. tty Issues and PRs related to the tty subsystem.
Projects
None yet
Development

No branches or pull requests

4 participants