test: increase specificity in dgram test #11187

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
6 participants
@Trott
Member

Trott commented Feb 5, 2017

Expand error message checking to include the entire error string in
test-dgram-membership.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test dgram

test: increase specificity in dgram test
Expand error message checking to include the entire error string in
test-dgram-membership.

@Trott Trott added dgram test labels Feb 5, 2017

@hiroppy

hiroppy approved these changes Feb 5, 2017

@jasnell

jasnell approved these changes Feb 6, 2017

@cjihrig

cjihrig approved these changes Feb 6, 2017

@hiroppy

This comment has been minimized.

Show comment
Hide comment
@lpinca

lpinca approved these changes Feb 7, 2017

@Trott

This comment has been minimized.

Show comment
Hide comment

Trott added a commit to Trott/io.js that referenced this pull request Feb 8, 2017

test: increase specificity in dgram test
Expand error message checking to include the entire error string in
test-dgram-membership.

PR-URL: nodejs#11187
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Feb 8, 2017

Member

Landed in 73f219f

Member

Trott commented Feb 8, 2017

Landed in 73f219f

@Trott Trott closed this Feb 8, 2017

italoacasas added a commit to italoacasas/node that referenced this pull request Feb 9, 2017

test: increase specificity in dgram test
Expand error message checking to include the entire error string in
test-dgram-membership.

PR-URL: nodejs#11187
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

italoacasas added a commit to italoacasas/node that referenced this pull request Feb 14, 2017

test: increase specificity in dgram test
Expand error message checking to include the entire error string in
test-dgram-membership.

PR-URL: nodejs#11187
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

KryDos added a commit to KryDos/node that referenced this pull request Feb 25, 2017

test: increase specificity in dgram test
Expand error message checking to include the entire error string in
test-dgram-membership.

PR-URL: nodejs#11187
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

jasnell added a commit that referenced this pull request Mar 7, 2017

test: increase specificity in dgram test
Expand error message checking to include the entire error string in
test-dgram-membership.

PR-URL: #11187
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

jasnell added a commit that referenced this pull request Mar 7, 2017

test: increase specificity in dgram test
Expand error message checking to include the entire error string in
test-dgram-membership.

PR-URL: #11187
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

MylesBorins added a commit that referenced this pull request Mar 9, 2017

test: increase specificity in dgram test
Expand error message checking to include the entire error string in
test-dgram-membership.

PR-URL: #11187
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@MylesBorins MylesBorins referenced this pull request Mar 9, 2017

Merged

v6.10.1 proposal #11759

MylesBorins added a commit that referenced this pull request Mar 9, 2017

test: increase specificity in dgram test
Expand error message checking to include the entire error string in
test-dgram-membership.

PR-URL: #11187
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@MylesBorins MylesBorins referenced this pull request Mar 9, 2017

Merged

v4.8.1 proposal #11760

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment