http: fix missing close event on aborted response #1373
Conversation
When sending a response after client aborted the connection in the same tick when the socket is already destroyed but the socket-close event is still not delivered, you did not get either a response-finish or a response-close event. This fix of the race-condition needs an additional flag "_finishOrCloseEmitted" in OutgoingMessage.
|
cc @indutny? |
| var testTickCount = 3; | ||
|
|
||
| var server = http.createServer(function (req, res) { | ||
| console.log('server: request'); |
There was a problem hiding this comment.
usually, passing tests should be silent; could you remove the expected console.logs?
There was a problem hiding this comment.
Of course I could remove them - I kept with the other tests which also contain console.logs (output is hidden anyway in normal test run).
I thought, especially race conditions are much more understandable with some debugging output - also for future refactoring/debugging.
There was a problem hiding this comment.
Please keep them for now :) I've a bit delayed this, but going to review it next week!
See next commit for the actual fix. PR-URL: nodejs#1373 Reviewed-By: Fedor Indutny <fedor@indutny.com>
Do not detach the socket from the response until all data is actually sent to the other side. See: nodejs#1373
|
@not-implemented PTAL at #1411 . I have integrated your test, but decided to choose a bit different way to fix the issue. |
|
Thank you for discovering this! |
|
Ah very cool ... I didn't have the guts to delay the WHOLE finish-handling - only parts of it ;-) |
|
Thank you! |
See next commit for the actual fix. PR-URL: nodejs#1373 Reviewed-By: Fedor Indutny <fedor@indutny.com>
Do not detach the socket from the response until all data is actually sent to the other side. See: nodejs#1373
See next commit for the actual fix. PR-URL: nodejs#1373 Reviewed-By: Fedor Indutny <fedor@indutny.com>
Do not detach the socket from the response until all data is actually sent to the other side. See: nodejs#1373
See next commit for the actual fix. PR-URL: #1373 Reviewed-By: Fedor Indutny <fedor@indutny.com>
See next commit for the actual fix. PR-URL: #1373 Reviewed-By: Fedor Indutny <fedor@indutny.com>
When sending a response after client aborted the connection in the same tick when the socket is already destroyed but the socket-close event is still not delivered, you did not get either a response-finish or a response-close event.
This fix of the race-condition needs an additional flag "_finishOrCloseEmitted" in OutgoingMessage.
I did not find any easier solution - I tried to fix this either with an additional "close" or an additional "finish" with some timing-tricks without an additional flag. I had no chance without breaking anything else.
Not all of the new checks of "_finishOrCloseEmitted" are currently really needed - they are just for completeness.