New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: fix timeout with null handle #16489

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
7 participants
@apapirovski
Member

apapirovski commented Oct 25, 2017

Seems like there's a scenario where _onTimeout somehow gets called with _handle set to null. If anyone has any ideas on how this is possible then let me know so I can put together a better test than I have so far.

This might need to be expedited (< 48 hrs) and turned into 8.8.1? Not sure... 馃様 馃槗 At least it's not LTS yet... *sigh*

Fixes: #16484
Refs: #15791

/cc @MylesBorins

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

net, test

@apapirovski

This comment has been minimized.

Show comment
Hide comment

@apapirovski apapirovski added this to the 9.0.0 milestone Oct 25, 2017

@apapirovski

This comment has been minimized.

Show comment
Hide comment
@apapirovski

apapirovski Oct 25, 2017

Member

CI seems good other than one persistently failing ARM machine (unrelated).

Member

apapirovski commented Oct 25, 2017

CI seems good other than one persistently failing ARM machine (unrelated).

@addaleax

Yeah, I鈥檇 be good with pushing out 8.8.1 asap 鈥 after all, that was a security release.

@nodejs/release

@jasnell

LGTM, +1 for fast tracking a patch release as long as it's not done on friday :-)

@refack

refack approved these changes Oct 25, 2017

@cjihrig

This comment has been minimized.

Show comment
Hide comment
@cjihrig

cjihrig Oct 25, 2017

Contributor

Landed in cecbb59. Thanks!

Contributor

cjihrig commented Oct 25, 2017

Landed in cecbb59. Thanks!

@cjihrig cjihrig closed this Oct 25, 2017

cjihrig added a commit that referenced this pull request Oct 25, 2017

net: fix timeout with null handle
This commit handles the case where _onTimeout is called with a
null handle.

Refs: #15791
Fixes: #16484
PR-URL: #16489
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>

addaleax added a commit to addaleax/node-core-utils that referenced this pull request Oct 25, 2017

cjihrig added a commit that referenced this pull request Oct 25, 2017

net: fix timeout with null handle
This commit handles the case where _onTimeout is called with a
null handle.

Refs: #15791
Fixes: #16484
PR-URL: #16489
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>

@apapirovski apapirovski deleted the apapirovski:patch-fix-net-timeout-throw branch Oct 25, 2017

cjihrig added a commit that referenced this pull request Oct 25, 2017

net: fix timeout with null handle
This commit handles the case where _onTimeout is called with a
null handle.

Refs: #15791
Fixes: #16484
PR-URL: #16489
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>

cjihrig added a commit that referenced this pull request Oct 25, 2017

2017-10-25, Version 8.8.1 (Current)
Notable changes:

* net:
  - Fix timeout with null handle issue. This is a regression in
    Node 8.8.0. #16489

@cjihrig cjihrig referenced this pull request Oct 25, 2017

Merged

v8.8.1 proposal #16498

apapirovski added a commit to apapirovski/node that referenced this pull request Oct 25, 2017

net: fix timeout with null handle
This commit handles the case where _onTimeout is called with a
null handle.

Refs: nodejs#15791
Fixes: nodejs#16484
PR-URL: nodejs#16489
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>

apapirovski added a commit to apapirovski/node that referenced this pull request Oct 25, 2017

net: fix timeout with null handle
This commit handles the case where _onTimeout is called with a
null handle.

Refs: nodejs#15791
Fixes: nodejs#16484
PR-URL: nodejs#16489
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>

cjihrig added a commit that referenced this pull request Oct 25, 2017

2017-10-25, Version 8.8.1 (Current)
Notable changes:

* net:
  - Fix timeout with null handle issue. This is a regression in
    Node 8.8.0. #16489

addaleax added a commit to addaleax/node-core-utils that referenced this pull request Oct 26, 2017

joyeecheung added a commit to nodejs/node-core-utils that referenced this pull request Oct 26, 2017

addaleax added a commit to ayojs/ayo that referenced this pull request Oct 26, 2017

net: fix timeout with null handle
This commit handles the case where _onTimeout is called with a
null handle.

Refs: nodejs/node#15791
Fixes: nodejs/node#16484
PR-URL: nodejs/node#16489
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>

addaleax added a commit to ayojs/ayo that referenced this pull request Oct 26, 2017

2017-10-25, Version 8.8.1 (Current)
Notable changes:

* net:
  - Fix timeout with null handle issue. This is a regression in
    Node 8.8.0. nodejs/node#16489
@MylesBorins

This comment has been minimized.

Show comment
Hide comment
@MylesBorins

MylesBorins Nov 16, 2017

Member

Should this be backported to v6.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

Member

MylesBorins commented Nov 16, 2017

Should this be backported to v6.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

addaleax added a commit to ayojs/ayo that referenced this pull request Dec 7, 2017

net: fix timeout with null handle
This commit handles the case where _onTimeout is called with a
null handle.

Refs: nodejs/node#15791
Fixes: nodejs/node#16484
PR-URL: nodejs/node#16489
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>

addaleax added a commit to ayojs/ayo that referenced this pull request Dec 7, 2017

2017-10-25, Version 8.8.1 (Current)
Notable changes:

* net:
  - Fix timeout with null handle issue. This is a regression in
    Node 8.8.0. nodejs/node#16489

apapirovski added a commit to apapirovski/node that referenced this pull request Dec 12, 2017

net: fix timeout with null handle
This commit handles the case where _onTimeout is called with a
null handle.

Refs: nodejs#15791
Fixes: nodejs#16484
PR-URL: nodejs#16489
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>

MylesBorins added a commit that referenced this pull request Dec 20, 2017

net: fix timeout with null handle
This commit handles the case where _onTimeout is called with a
null handle.

Backport-PR-URL: #16420
Refs: #15791
Fixes: #16484
PR-URL: #16489
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>

MylesBorins added a commit that referenced this pull request Jan 2, 2018

net: fix timeout with null handle
This commit handles the case where _onTimeout is called with a
null handle.

Backport-PR-URL: #16420
Refs: #15791
Fixes: #16484
PR-URL: #16489
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>

@MylesBorins MylesBorins referenced this pull request Jan 24, 2018

Merged

v6.13.0 proposal #18342

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment