net: fix timeout with null handle #16489

apapirovski · 2017-10-25T13:30:57Z

Seems like there's a scenario where _onTimeout somehow gets called with _handle set to null. If anyone has any ideas on how this is possible then let me know so I can put together a better test than I have so far.

This might need to be expedited (< 48 hrs) and turned into 8.8.1? Not sure... 😔 😓 At least it's not LTS yet... *sigh*

Fixes: #16484
Refs: #15791

/cc @MylesBorins

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines

Affected core subsystem(s)

net, test

apapirovski · 2017-10-25T15:39:43Z

CI: https://ci.nodejs.org/job/node-test-pull-request/10968/

apapirovski · 2017-10-25T16:41:27Z

CI seems good other than one persistently failing ARM machine (unrelated).

addaleax

Yeah, I’d be good with pushing out 8.8.1 asap – after all, that was a security release.

@nodejs/release

jasnell

LGTM, +1 for fast tracking a patch release as long as it's not done on friday :-)

cjihrig · 2017-10-25T18:51:45Z

Landed in cecbb59. Thanks!

This commit handles the case where _onTimeout is called with a null handle. Refs: #15791 Fixes: #16484 PR-URL: #16489 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>

i.e. make `get-metadata https://github.com/nodejs/node/pull/16489` work

This commit handles the case where _onTimeout is called with a null handle. Refs: #15791 Fixes: #16484 PR-URL: #16489 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>

Notable changes: * net: - Fix timeout with null handle issue. This is a regression in Node 8.8.0. #16489

This commit handles the case where _onTimeout is called with a null handle. Refs: nodejs#15791 Fixes: nodejs#16484 PR-URL: nodejs#16489 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>

Notable changes: * net: - Fix timeout with null handle issue. This is a regression in Node 8.8.0. #16489

i.e. make `get-metadata https://github.com/nodejs/node/pull/16489` work

This commit handles the case where _onTimeout is called with a null handle. Refs: nodejs/node#15791 Fixes: nodejs/node#16484 PR-URL: nodejs/node#16489 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>

Notable changes: * net: - Fix timeout with null handle issue. This is a regression in Node 8.8.0. nodejs/node#16489

MylesBorins · 2017-11-16T21:07:59Z

Should this be backported to v6.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

This commit handles the case where _onTimeout is called with a null handle. Refs: nodejs/node#15791 Fixes: nodejs/node#16484 PR-URL: nodejs/node#16489 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>

Notable changes: * net: - Fix timeout with null handle issue. This is a regression in Node 8.8.0. nodejs/node#16489

This commit handles the case where _onTimeout is called with a null handle. Refs: nodejs#15791 Fixes: nodejs#16484 PR-URL: nodejs#16489 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>

This commit handles the case where _onTimeout is called with a null handle. Backport-PR-URL: #16420 Refs: #15791 Fixes: #16484 PR-URL: #16489 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>

i.e. make `get-metadata https://github.com/nodejs/node/pull/16489` work

net: fix timeout with null handle

aae40d9

apapirovski added confirmed-bug Issues with confirmed bugs. net Issues and PRs related to the net subsystem. labels Oct 25, 2017

apapirovski requested review from jasnell and addaleax October 25, 2017 13:30

nodejs-github-bot added the net Issues and PRs related to the net subsystem. label Oct 25, 2017

apapirovski removed the confirmed-bug Issues with confirmed bugs. label Oct 25, 2017

apapirovski mentioned this pull request Oct 25, 2017

net.js broken in node 8.8 #16484

Closed

apapirovski added this to the 9.0.0 milestone Oct 25, 2017

addaleax approved these changes Oct 25, 2017

View reviewed changes

jasnell approved these changes Oct 25, 2017

View reviewed changes

cjihrig approved these changes Oct 25, 2017

View reviewed changes

refack approved these changes Oct 25, 2017

View reviewed changes

cjihrig closed this Oct 25, 2017

addaleax referenced this pull request in addaleax/node-core-utils Oct 25, 2017

allow passing full URLs on the command line

c7d4668

i.e. make `get-metadata https://github.com/nodejs/node/pull/16489` work

apapirovski deleted the patch-fix-net-timeout-throw branch October 25, 2017 19:09

cjihrig added a commit that referenced this pull request Oct 25, 2017

2017-10-25, Version 8.8.1 (Current)

dc6bbb4

Notable changes: * net: - Fix timeout with null handle issue. This is a regression in Node 8.8.0. #16489

cjihrig mentioned this pull request Oct 25, 2017

v8.8.1 proposal #16498

Merged

cjihrig added a commit that referenced this pull request Oct 25, 2017

2017-10-25, Version 8.8.1 (Current)

e8de2bf

Notable changes: * net: - Fix timeout with null handle issue. This is a regression in Node 8.8.0. #16489

addaleax referenced this pull request in addaleax/node-core-utils Oct 26, 2017

allow passing full URLs on the command line

04a5792

i.e. make `get-metadata https://github.com/nodejs/node/pull/16489` work

joyeecheung referenced this pull request in nodejs/node-core-utils Oct 26, 2017

allow passing full URLs on the command line (#6)

15a2c27

i.e. make `get-metadata https://github.com/nodejs/node/pull/16489` work

addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 26, 2017

2017-10-25, Version 8.8.1 (Current)

f34f9d0

Notable changes: * net: - Fix timeout with null handle issue. This is a regression in Node 8.8.0. nodejs/node#16489

MylesBorins added the backport-requested-v6.x label Nov 16, 2017

addaleax pushed a commit to ayojs/ayo that referenced this pull request Dec 7, 2017

2017-10-25, Version 8.8.1 (Current)

8dd9f34

Notable changes: * net: - Fix timeout with null handle issue. This is a regression in Node 8.8.0. nodejs/node#16489

mcollina mentioned this pull request Dec 20, 2017

[v6.x backport] tls: fix writeQueueSize prop, long write timeouts #16420

Closed

3 tasks

apapirovski added dont-land-on-v4.x and removed backport-requested-v6.x labels Jan 10, 2018

MylesBorins mentioned this pull request Jan 24, 2018

v6.13.0 proposal #18342

Merged

johnfrench3 referenced this pull request in johnfrench3/core-utils-node Nov 2, 2022

allow passing full URLs on the command line (#6)

0a6c651

i.e. make `get-metadata https://github.com/nodejs/node/pull/16489` work

renawolford6 referenced this pull request in renawolford6/node-dev-build-core-utils Nov 10, 2022

allow passing full URLs on the command line (#6)

f491ef7

i.e. make `get-metadata https://github.com/nodejs/node/pull/16489` work

Developerarif2 referenced this pull request in Developerarif2/node-core-utils Jan 27, 2023

allow passing full URLs on the command line (#6)

454fdb3

i.e. make `get-metadata https://github.com/nodejs/node/pull/16489` work

gerkai referenced this pull request in gerkai/node-core-utils-project-build Jan 27, 2023

allow passing full URLs on the command line (#6)

181bac4

i.e. make `get-metadata https://github.com/nodejs/node/pull/16489` work

shovon58 referenced this pull request in shovon58/node-core-utils Jun 9, 2023

allow passing full URLs on the command line (#6)

c46f31c

i.e. make `get-metadata https://github.com/nodejs/node/pull/16489` work

patrickm68 referenced this pull request in patrickm68/NodeJS-core-utils Sep 14, 2023

allow passing full URLs on the command line (#6)

62fc6e8

i.e. make `get-metadata https://github.com/nodejs/node/pull/16489` work

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

net: fix timeout with null handle #16489

net: fix timeout with null handle #16489

apapirovski commented Oct 25, 2017 •

edited

Loading

apapirovski commented Oct 25, 2017

apapirovski commented Oct 25, 2017 •

edited

Loading

addaleax left a comment

jasnell left a comment

cjihrig commented Oct 25, 2017

MylesBorins commented Nov 16, 2017

net: fix timeout with null handle #16489

net: fix timeout with null handle #16489

Conversation

apapirovski commented Oct 25, 2017 • edited Loading

Checklist

Affected core subsystem(s)

apapirovski commented Oct 25, 2017

apapirovski commented Oct 25, 2017 • edited Loading

addaleax left a comment

Choose a reason for hiding this comment

jasnell left a comment

Choose a reason for hiding this comment

cjihrig commented Oct 25, 2017

MylesBorins commented Nov 16, 2017

apapirovski commented Oct 25, 2017 •

edited

Loading

apapirovski commented Oct 25, 2017 •

edited

Loading