-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
loader: test search module #16795
loader: test search module #16795
Conversation
1 similar comment
@joyeecheung Hi, thanks for running the CI. The build is stuck since 5 hours. What should I do ? |
@clakech All the CI runs are done except an AIX host which only became available for this CI run about 10 minutes ago. Everything else passed, so I'm pretty sure the AIX host will pass too. |
As my father used to say: "Famous last words..." AIX failed, but it's unrelated. I opened an issue about the failure at #16859. Meanwhile, this can land. |
Er, well, it should stay up for another day or two before landing. But I mean, Ci is OK. (Of course if any changes are requested and made, we'll need to re-run CI.) |
hi @Trott, should we launch another CI build ? or it could land as is ? |
PR-URL: #16795 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Landed in e0113ab |
PR-URL: #16795 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #16795 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Checklist
make -j4 test
(UNIX)