util: improve error message of _errnoException #17626
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
util
BridgeAR
approved these changes
Dec 12, 2017
Trott
approved these changes
Dec 12, 2017
Trott
added
semver-major
|
Out of caution, labeling @nodejs/tsc: I think this one should be patch rather than major. Is there consensus on that? If so, I'll remove the |
cjihrig
approved these changes
Dec 12, 2017
evanlucas
approved these changes
Dec 12, 2017
gireeshpunathil
approved these changes
Dec 13, 2017
lpinca
approved these changes
Dec 13, 2017
joyeecheung
approved these changes
Dec 16, 2017
lib/util.js
Outdated
| } | ||
| if (err >= 0 || !Number.isSafeInteger(err)) { | ||
| throw new errors.RangeError('ERR_VALUE_OUT_OF_RANGE', 'err', | ||
| 'a negative number', err); |
There was a problem hiding this comment.
Since there is an integer check and the type name is already in prose style, maybe change this to 'a negative integer' for better clarity?
|
@Trott The changed error is new in v9.x, I doubt this change could cause any serious breakage, so I am +1 on marking this semver-patch. |
starkwang
force-pushed
the
util-improve-err-msg
branch
from
cdf951d
to
9c8a78c
Compare
jasnell
approved these changes
Dec 28, 2017
|
I'd prefer this as semver-major |
|
CI seems failed. I'm fixing it. |
The usage of ERR_INVALID_ARG_TYPE in _errnoException is a little inappropriate. This change is to improve it.
starkwang
force-pushed
the
util-improve-err-msg
branch
from
9c8a78c
to
8e7d18e
Compare
|
Landed in c64ca56 |
starkwang
added a commit
that referenced
this pull request
Dec 29, 2017
The usage of ERR_INVALID_ARG_TYPE in _errnoException is a little inappropriate. This change is to improve it. PR-URL: #17626 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The usage of ERR_INVALID_ARG_TYPE in _errnoException is a little inappropriate. This change is to improve it.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
util