doc: add more detail for callback of http res/req end method #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add documentation for the callback parameter of http.ClientRequest's and http.ServerResponse's end methods.
|
Original PR URL: joyent/node#8851. BTW, there is still a chance that it could get merged at This pull request gets a 👍 from me, it doesn't make much sense to leave the callback parameter undocumented. |
bnoordhuis
pushed a commit
that referenced
this pull request
Dec 18, 2014
Add documentation for the callback parameter of http.ClientRequest's and http.ServerResponse's end methods. PR-URL: #181 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Brendan Ashworth <squirrelslikeacorns@gmail.com>
|
Landed in a553267, cheers! |
|
@brendanashworth For the future, could you rephrase "would you be interested in re-opening this PR at iojs" to "are you still interested in maintaining this PR?" and CC me on the issue? I'll try to make sure it gets into joyent/node, I'll try to make sure it makes it in here as well. |
|
@chrisdickinson sure! Thanks for the tip. |
jasongin
added a commit
to jasongin/nodejs
that referenced
this pull request
Mar 23, 2017
boingoing
pushed a commit
to boingoing/node
that referenced
this pull request
Apr 6, 2017
This was referenced May 26, 2021
eti-p-doray
pushed a commit
to eti-p-doray/node
that referenced
this pull request
May 28, 2024
* Add node_enable_deprecated_declarations_warnings GN flag Warnings about using deprecated declarations were disabled by default which made it hard to ensure that Node doesn't use V8's deprecated Apis. The flag allows enabling deprecated warnings and suppresses (hopefully) known issues with using deprecated functionality in c-api. The flag is off by default which preserves the existing behavior. Drive-by: fix deps/openssl/unofficial.gni by exposing the required OpenSSL compatibility level (OPENSSL_API_COMPAT) via public_configs.
syg
pushed a commit
to syg/node
that referenced
this pull request
Jun 20, 2024
* Add node_enable_deprecated_declarations_warnings GN flag Warnings about using deprecated declarations were disabled by default which made it hard to ensure that Node doesn't use V8's deprecated Apis. The flag allows enabling deprecated warnings and suppresses (hopefully) known issues with using deprecated functionality in c-api. The flag is off by default which preserves the existing behavior. Drive-by: fix deps/openssl/unofficial.gni by exposing the required OpenSSL compatibility level (OPENSSL_API_COMPAT) via public_configs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add documentation for the callback parameter of http.ClientRequest's and
http.ServerResponse's end methods.