Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util: add bigint formatting to util.inspect #18412

Closed
wants to merge 1 commit into from
Closed

util: add bigint formatting to util.inspect #18412

wants to merge 1 commit into from

Conversation

devsnek
Copy link
Member

@devsnek devsnek commented Jan 27, 2018 •
edited
Loading

bigints found their way into node master at some point and as i've been experimenting with them i got increasingly annoyed at not being able to tell the difference between them and numbers in the repl, so i made this.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

util

@nodejs-github-bot nodejs-github-bot added the util Issues and PRs related to the built-in util module. label Jan 27, 2018
@addaleax
Copy link
Member

Can you add util: to the commit message?

joyeecheung
joyeecheung approved these changes Jan 27, 2018
View reviewed changes
Copy link
Member

@joyeecheung joyeecheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, I also got something similar locally to play around with bigint. Although I am not sure what is our policy wrt. wip ECMAscript features that still requires a harmony flag (although in this case it's test-only)

evanlucas
evanlucas approved these changes Jan 27, 2018
View reviewed changes
Copy link
Contributor

@evanlucas evanlucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the commit message updated

cjihrig
cjihrig approved these changes Jan 27, 2018
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slight preference to include the test in test/parallel/test-util-inspect instead of a new file. Other than that, LGTM.

@devsnek
Copy link
Member Author

devsnek commented Jan 27, 2018

@cjihrig i put it in the new file because of the flag and still being "experimental", but i will move it when the flag is removed (i have a sticky note on my desk about it)

@BridgeAR BridgeAR added the semver-minor PRs that contain new features and should be released in the next minor version. label Jan 28, 2018
ChALkeR
ChALkeR approved these changes Jan 30, 2018
View reviewed changes
Copy link
Member

@ChALkeR ChALkeR left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after formatting the commit message to follow commit guidelines (i.e. the first line should use the prefix: format, like in examples).

That said, technically the commit guidelines don't mention that subsystem should be separated from the rest of the commit message with a colon.

@devsnek
Copy link
Member Author

devsnek commented Jan 30, 2018

@ChALkeR nah that's my bad, i just confuse all the different formatting guides all the different projects across github use, fixed now

@devsnek devsnek changed the title [util] add bigint formatting to util.inspect util: add bigint formatting to util.inspect Jan 30, 2018
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 31, 2018
@BridgeAR
Copy link
Member

CI https://ci.nodejs.org/job/node-test-pull-request/12824/

@BridgeAR
Copy link
Member

BridgeAR commented Feb 1, 2018

Landed in 39dc947

@BridgeAR BridgeAR closed this Feb 1, 2018
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Feb 1, 2018
@devsnek @BridgeAR
util: add bigint formatting to util.inspect
39dc947 
PR-URL: nodejs#18412
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@devsnek devsnek deleted the feature/util-inspect-bigint branch February 2, 2018 14:47
@addaleax addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 4, 2018
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@devsnek @MayaLekova
util: add bigint formatting to util.inspect
36dc165 
PR-URL: nodejs#18412
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@evanlucas evanlucas evanlucas approved these changes

@jasnell jasnell jasnell approved these changes

@ChALkeR ChALkeR ChALkeR approved these changes

Assignees
No one assigned
Labels
semver-minor PRs that contain new features and should be released in the next minor version. util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.