New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: add bigint formatting to util.inspect #18412

Closed
wants to merge 1 commit into
base: master
from

Conversation

@devsnek
Member

devsnek commented Jan 27, 2018

bigints found their way into node master at some point and as i've been experimenting with them i got increasingly annoyed at not being able to tell the difference between them and numbers in the repl, so i made this.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

util

@addaleax

This comment has been minimized.

Member

addaleax commented Jan 27, 2018

Can you add util: to the commit message?

@joyeecheung

Code LGTM, I also got something similar locally to play around with bigint. Although I am not sure what is our policy wrt. wip ECMAscript features that still requires a harmony flag (although in this case it's test-only)

@lpinca

lpinca approved these changes Jan 27, 2018

@evanlucas

LGTM with the commit message updated

@cjihrig

Slight preference to include the test in test/parallel/test-util-inspect instead of a new file. Other than that, LGTM.

@devsnek

This comment has been minimized.

Member

devsnek commented Jan 27, 2018

@cjihrig i put it in the new file because of the flag and still being "experimental", but i will move it when the flag is removed (i have a sticky note on my desk about it)

@ChALkeR

ChALkeR approved these changes Jan 30, 2018 edited

LGTM after formatting the commit message to follow commit guidelines (i.e. the first line should use the prefix: format, like in examples).

That said, technically the commit guidelines don't mention that subsystem should be separated from the rest of the commit message with a colon.

@devsnek

This comment has been minimized.

Member

devsnek commented Jan 30, 2018

@ChALkeR nah that's my bad, i just confuse all the different formatting guides all the different projects across github use, fixed now

@devsnek devsnek changed the title from [util] add bigint formatting to util.inspect to util: add bigint formatting to util.inspect Jan 30, 2018

@BridgeAR

This comment has been minimized.

@BridgeAR

This comment has been minimized.

Member

BridgeAR commented Feb 1, 2018

Landed in 39dc947

@BridgeAR BridgeAR closed this Feb 1, 2018

BridgeAR added a commit to BridgeAR/node that referenced this pull request Feb 1, 2018

util: add bigint formatting to util.inspect
PR-URL: nodejs#18412
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

kcaulfield94 added a commit to kcaulfield94/node that referenced this pull request Feb 2, 2018

util: add bigint formatting to util.inspect
PR-URL: nodejs#18412
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

@devsnek devsnek deleted the devsnek:feature/util-inspect-bigint branch Feb 2, 2018

@addaleax addaleax removed the author ready label Feb 4, 2018

msoechting added a commit to hpicgs/node that referenced this pull request Feb 5, 2018

util: add bigint formatting to util.inspect
PR-URL: nodejs#18412
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

msoechting added a commit to hpicgs/node that referenced this pull request Feb 7, 2018

util: add bigint formatting to util.inspect
PR-URL: nodejs#18412
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

MayaLekova added a commit to MayaLekova/node that referenced this pull request May 8, 2018

util: add bigint formatting to util.inspect
PR-URL: nodejs#18412
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment