test: fix test-child-process-send-returns-boolean #20136
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test-child-process-send-returns-boolean was unreliable in CI and locally. * use 'SIGKILL' for more reliable process termination * replace callback with assert.ifError() * increase interval in fixture from 500ms to 9999ms. It's only purpose is to keep the process from exiting. Fixes: nodejs#20135
|
From #20135:
Maybe set the timeout in the child process to a few minutes and have it exit afterwards. By then, it should have either been killed, or we can assume something went wrong with the test. |
|
Stress test against master (should fail): https://ci.nodejs.org/job/node-stress-single-test/1823/ Stress test against this PR (should pass): https://ci.nodejs.org/job/node-stress-single-test/1824/ |
jasnell
approved these changes
Apr 18, 2018
|
macOS re-run (failure was in an unrelated test): https://ci.nodejs.org/job/node-test-commit-osx/17928/ |
lpinca
approved these changes
Apr 19, 2018
trivikr
approved these changes
Apr 19, 2018
hiroppy
approved these changes
Apr 19, 2018
|
Re-run of the macOS re-run: https://ci.nodejs.org/job/node-test-commit-osx/17978/ |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Apr 20, 2018
test-child-process-send-returns-boolean was unreliable in CI and locally. * use 'SIGKILL' for more reliable process termination * replace callback with assert.ifError() * increase interval in fixture from 500ms to 9999ms. It's only purpose is to keep the process from exiting. Fixes: nodejs#20135 PR-URL: nodejs#20136 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
|
Landed in 6e6913b |
jasnell
pushed a commit
that referenced
this pull request
Apr 20, 2018
test-child-process-send-returns-boolean was unreliable in CI and locally. * use 'SIGKILL' for more reliable process termination * replace callback with assert.ifError() * increase interval in fixture from 500ms to 9999ms. It's only purpose is to keep the process from exiting. Fixes: #20135 PR-URL: #20136 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test-child-process-send-returns-boolean was unreliable in CI and
locally.
is to keep the process from exiting.
Fixes: #20135
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes