test: refactor child-process-fork-net #21095
Conversation
Split test-child-process-fork-net into test-child-process-fork-net-server and test-child-process-fork-net-socket. Rename test-child-process-fork-net2.js to test-child-process-fork-net.js. Refs: nodejs#21012
Trott
added
the
author ready
|
Hmmm...both times, the test run for Windows was green. @targos Any chance you can pull down test-child-process-fork-net-socket from this PR and see if it fails for you on your Windows machine? While at it, maybe we can see if that |
|
Stress test of the current test monolith on master: https://ci.nodejs.org/job/node-stress-single-test/1898/nodes=win2016-1p-vs2017/ Stress test of the previously (and perhaps still?) unreliable portion of that above test as refactored in this PR will be here once that one above finishes running: https://ci.nodejs.org/job/node-stress-single-test/1902/nodes=win2016-1p-vs2017/ I don't expect that the results will be different form each other, but if they are, then I guess that definitely points to side effects being an issue in the current test instability. |
|
@Trott I'm compiling your branch just to be sure but yes, it still fails for me, more than 75% of the runs. |
|
Failure is more difficult to obtain with this branch (maybe because of the V8 upgrade?) but it still happens! |
|
Landed in 3c5b8b4 |
Split test-child-process-fork-net into test-child-process-fork-net-server and test-child-process-fork-net-socket. Rename test-child-process-fork-net2.js to test-child-process-fork-net.js. Refs: #21012 PR-URL: #21095 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos
removed
the
author ready
Split test-child-process-fork-net into test-child-process-fork-net-server and test-child-process-fork-net-socket. Rename test-child-process-fork-net2.js to test-child-process-fork-net.js. Refs: #21012 PR-URL: #21095 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Split test-child-process-fork-net into
test-child-process-fork-net-server and
test-child-process-fork-net-socket. Rename
test-child-process-fork-net2.js to test-child-process-fork-net.js.
Refs: #21012
One of the files involved here is actively being worked on in an effort to make it not flaky. If the fix ends up being to the test (rather than a bug in Node.js itself), it will have a merge conflict with this. I'll rebase or close if that happens. (Just don't want the people working on the test to see this and get annoyed or worried or something along those lines.)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes