deps,npm: float node-gyp patch on npm #21239
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This small change makes addon test build successfully with LLVM 10.0.0 and above. This will be fixed in npm source when node-gyp is updated to 3.6.3 or above.
Trott
added
npm
nodejs-github-bot
added
the
npm
|
CI: https://ci.nodejs.org/job/node-test-pull-request/15367/ Edit by @addaleax: 👍 for fast-track |
addaleax
approved these changes
Jun 10, 2018
JungMinu
approved these changes
Jun 10, 2018
cjihrig
approved these changes
Jun 10, 2018
joyeecheung
approved these changes
Jun 10, 2018
|
PR on npm: npm/npm#20948 |
|
Only CI issue was a stalled/Jenkins communication thing. Re-run: https://ci.nodejs.org/job/node-test-pull-request/15370/ |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jun 10, 2018
This small change makes addon test build successfully with LLVM 10.0.0 and above. This will be fixed in npm source when node-gyp is updated to 3.6.3 or above. PR-URL: nodejs#21239 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
|
Landed in 0454725 |
targos
pushed a commit
that referenced
this pull request
Jun 10, 2018
This small change makes addon test build successfully with LLVM 10.0.0 and above. This will be fixed in npm source when node-gyp is updated to 3.6.3 or above. PR-URL: #21239 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small change makes addon test build successfully with LLVM
10.0.0 and above. This will be fixed in npm source when node-gyp
is updated to 3.6.3 or above.
Without this, it is not possible to successfully run
make testwith LLVM 10.0.0.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes