Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: flaky everywhere test-trace-events-fs-sync #22483

Closed
wants to merge 1 commit into from
Closed

test: flaky everywhere test-trace-events-fs-sync #22483

wants to merge 1 commit into from

Conversation

refack
Copy link
Contributor

@refack refack commented Aug 23, 2018

Refs: #21038

👍 to fast-track (if you agree)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@refack refack added test Issues and PRs related to the tests. trace_events Issues and PRs related to V8, Node.js core, and userspace code trace events. flaky-test Issues and PRs related to the tests with unstable failures on the CI. fast-track PRs that do not need to wait for 48 hours to land. labels Aug 23, 2018
@nodejs-github-bot
Copy link
Collaborator

@refack build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/648/pipeline

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Aug 23, 2018
@refack
Copy link
Contributor Author

refack commented Aug 23, 2018

/CC @nodejs/testing

@refack
Copy link
Contributor Author

refack commented Aug 23, 2018

/CC @nodejs/trace-events

@addaleax
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/16724/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 24, 2018
@refack
Copy link
Contributor Author

refack commented Aug 24, 2018 •
edited
Loading

ARM only rebuild: https://ci.nodejs.org/job/node-test-commit-arm-fanned/3196/ ✔️

@addaleax
Copy link
Member

Landed in 3579ec4

@addaleax addaleax closed this Aug 24, 2018
addaleax pushed a commit that referenced this pull request Aug 24, 2018
@refack @addaleax
test: flaky everywhere test-trace-events-fs-sync
3579ec4 
Refs: #21038

PR-URL: #22483
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@refack refack deleted the escelate-flakiness-trace-events-fs-sync branch August 24, 2018 19:01
addaleax pushed a commit that referenced this pull request Aug 27, 2018
@refack @addaleax
test: flaky everywhere test-trace-events-fs-sync
043e9dd 
Refs: #21038

PR-URL: #22483
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Sep 3, 2018
@refack @targos
test: flaky everywhere test-trace-events-fs-sync
6d0c3d1 
Refs: #21038

PR-URL: #22483
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Sep 5, 2018
Merged
targos pushed a commit that referenced this pull request Sep 6, 2018
@refack @targos
test: flaky everywhere test-trace-events-fs-sync
c04f1f3 
Refs: #21038

PR-URL: #22483
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Sep 6, 2018
Closed
Closed
@refack refack mentioned this pull request Oct 18, 2018
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyeecheung joyeecheung joyeecheung approved these changes

@addaleax addaleax addaleax approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests. trace_events Issues and PRs related to V8, Node.js core, and userspace code trace events.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@refack @nodejs-github-bot @addaleax @jasnell @Trott @joyeecheung