Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade to libuv 1.23.1 #22997

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
8 participants
@cjihrig
Copy link
Contributor

commented Sep 21, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@addaleax
Copy link
Member

left a comment

Fixes: https://github.com/nodejs/node/issues/22814

@addaleax

This comment has been minimized.

@mcollina
Copy link
Member

left a comment

LGTM

@addaleax

This comment has been minimized.

Copy link
Member

commented Sep 22, 2018

@BridgeAR
Copy link
Member

left a comment

RSLGTM

@danbev

This comment has been minimized.

Copy link
Member

commented Sep 24, 2018

Landed in 2790db5.

@danbev danbev closed this Sep 24, 2018

danbev added a commit that referenced this pull request Sep 24, 2018

deps: upgrade to libuv 1.23.1
PR-URL: #22997
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

targos added a commit that referenced this pull request Sep 24, 2018

deps: upgrade to libuv 1.23.1
PR-URL: #22997
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

@joyeecheung joyeecheung referenced this pull request Sep 25, 2018

Closed

CI failures: 20180925 #17

@Trott

This comment has been minimized.

Copy link
Member

commented Oct 4, 2018

After talking a bit with @addaleax, I did a bisect using a series of stress tests to determine what commit introduced the unreliability for test-gc-net-timeout (and likely the other test-gc-* files). Unfortunately, the commit where the problem was introduced is the one in this PR.

Ref: https://gist.github.com/Trott/d3c3b5e4419497fdc8651ac2d5f805c7

@addaleax

This comment has been minimized.

Copy link
Member

commented Oct 4, 2018

Went through the individual libuv commits in nodejs/reliability#18 (comment)

MylesBorins added a commit to MylesBorins/node that referenced this pull request Nov 5, 2018

deps: upgrade to libuv 1.23.1
PR-URL: nodejs#22997
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

MylesBorins added a commit to MylesBorins/node that referenced this pull request Nov 5, 2018

deps: upgrade to libuv 1.23.1
PR-URL: nodejs#22997
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

MylesBorins added a commit that referenced this pull request Nov 11, 2018

deps: upgrade to libuv 1.23.1
Backport-PR-URL: #24103
PR-URL: #22997
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

@BethGriggs BethGriggs referenced this pull request Nov 12, 2018

Merged

v8.13.0 proposal #23974

@shuhei shuhei referenced this pull request Jan 19, 2019

Closed

nameserver discovery #19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.