Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: move module exports proxy into a separate method #24057

Closed
wants to merge 1 commit into from

Conversation

@joyeecheung
Copy link
Member

commented Nov 3, 2018

Also added the comment in f074612 to make
NativeModule.prototype.compile() more readable.

lib: move module exports proxy into a separate method
Also added the comment in f074612 to make
NativeModule.prototype.compile() more readable.

@joyeecheung joyeecheung requested a review from devsnek Nov 3, 2018

@joyeecheung

This comment has been minimized.

Copy link
Member Author

commented Nov 3, 2018

@devsnek
devsnek approved these changes Nov 3, 2018
@refack
refack approved these changes Nov 3, 2018
joyeecheung added a commit to joyeecheung/node that referenced this pull request Nov 4, 2018
lib: move module exports proxy into a separate method
Also added the comment in f074612 to make
NativeModule.prototype.compile() more readable.

PR-URL: nodejs#24057
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@danbev

This comment has been minimized.

Copy link
Member

commented Nov 6, 2018

Landed in c3b674c.

@danbev danbev closed this Nov 6, 2018

danbev added a commit that referenced this pull request Nov 6, 2018
lib: move module exports proxy into a separate method
Also added the comment in f074612 to make
NativeModule.prototype.compile() more readable.

PR-URL: #24057
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Refael Ackermann <refack@gmail.com>
targos added a commit that referenced this pull request Nov 6, 2018
lib: move module exports proxy into a separate method
Also added the comment in f074612 to make
NativeModule.prototype.compile() more readable.

PR-URL: #24057
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@BridgeAR BridgeAR referenced this pull request Nov 14, 2018
codebytere added a commit that referenced this pull request Nov 29, 2018
lib: move module exports proxy into a separate method
Also added the comment in f074612 to make
NativeModule.prototype.compile() more readable.

PR-URL: #24057
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Refael Ackermann <refack@gmail.com>
MylesBorins added a commit that referenced this pull request Nov 29, 2018
lib: move module exports proxy into a separate method
Also added the comment in f074612 to make
NativeModule.prototype.compile() more readable.

PR-URL: #24057
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@codebytere codebytere referenced this pull request Nov 29, 2018
MylesBorins added a commit that referenced this pull request Dec 3, 2018
lib: move module exports proxy into a separate method
Also added the comment in f074612 to make
NativeModule.prototype.compile() more readable.

PR-URL: #24057
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.